Skip to content

Commit 0ce30a1

Browse files
muyangyuapplechanglan
authored andcommitted
add some env vars to jobset
GitOrigin-RevId: 67dd26c
1 parent caf6732 commit 0ce30a1

2 files changed

Lines changed: 35 additions & 0 deletions

File tree

axlearn/cloud/gcp/jobset_utils.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,29 @@ def _build_container(self) -> Nested[Any]:
502502
k8s_env_vars.append(
503503
{"name": "NODE_NAME", "valueFrom": {"fieldRef": {"fieldPath": "spec.nodeName"}}}
504504
)
505+
# pylint: disable=line-too-long
506+
k8s_env_vars.append(
507+
{
508+
"name": "NUM_REPLICAS",
509+
"valueFrom": {
510+
"fieldRef": {
511+
"fieldPath": "metadata.annotations['jobset.sigs.k8s.io/replicatedjob-replicas']"
512+
}
513+
},
514+
}
515+
)
516+
# pylint: enable=line-too-long
517+
518+
k8s_env_vars.append(
519+
{
520+
"name": "REPLICA_ID",
521+
"valueFrom": {
522+
"fieldRef": {
523+
"fieldPath": "metadata.annotations['jobset.sigs.k8s.io/job-index']"
524+
}
525+
},
526+
}
527+
)
505528

506529
return dict(
507530
name=cfg.name,

axlearn/cloud/gcp/jobset_utils_test.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,18 @@ def test_build_pod(
359359
container_env["NODE_IP"]["valueFrom"]["fieldRef"]["fieldPath"],
360360
)
361361

362+
# Verify NUM_REPLICAS in container env.
363+
self.assertEqual(
364+
"metadata.annotations['jobset.sigs.k8s.io/replicatedjob-replicas']",
365+
container_env["NUM_REPLICAS"]["valueFrom"]["fieldRef"]["fieldPath"],
366+
)
367+
368+
# Verify REPLICA_ID in container env.
369+
self.assertEqual(
370+
"metadata.annotations['jobset.sigs.k8s.io/job-index']",
371+
container_env["REPLICA_ID"]["valueFrom"]["fieldRef"]["fieldPath"],
372+
)
373+
362374
# Verify uploader container specs
363375
self.assertEqual(len(pod_spec["initContainers"]), 1)
364376

0 commit comments

Comments
 (0)