Skip to content

Commit 8ff1056

Browse files
committed
Added (*) in "axlearn/common/flash_attention/layer_test.py" L529 to
unpack Tuple before converting it to PartitionSpec. This fixes the issue of having: AssertionError: P('data', None) != P(('data', None),)
1 parent 349ad48 commit 8ff1056

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

axlearn/common/flash_attention/layer_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ def as_partition_spec(pytree: CompositeAttentionBias) -> PartitionSpec:
526526
spec = test_layer._logit_biases_spec(segment_ids) # pylint: disable=protected-access
527527
spec = as_partition_spec(spec)
528528
self.assertIsInstance(spec, PartitionSpec)
529-
self.assertEqual(spec, as_partition_spec(test_layer.config.mha_dim_to_partition_spec["btnh"][:2]))
529+
self.assertEqual(spec, jax.P(*test_layer.config.mha_dim_to_partition_spec["btnh"][:2]))
530530

531531
@parameterized.product(
532532
_TEST_CONFIGS,

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ core = [
2525
"chex==0.1.91",
2626
"etils[epy]==1.13.0", # pin to ensure importlib-resources is installed (needed by tensorflow-datasets)
2727
"importlab==0.8.1", # breaks pytype on 0.8
28-
"jax>=0.9.1.dev20260130,<0.9.2",
29-
"jaxlib>=0.9.1.dev20260130,<0.9.2",
28+
"jax==0.10.0",
29+
"jaxlib>=0.10.0",
3030
"ml-dtypes==0.5.3",
3131
"msgpack==1.1.0", # for checkpointing.
3232
"nltk==3.7", # for text preprocessing
@@ -108,7 +108,7 @@ gcp = [
108108
# Note: Specify -f https://storage.googleapis.com/jax-releases/libtpu_releases.html during install.
109109
tpu = [
110110
"axlearn[gcp]",
111-
"jax[tpu]>=0.9.1.dev20260130,<0.9.2", # must be >=0.4.19 for compat with v5p.
111+
"jax[tpu]==0.10.0", # must be >=0.4.19 for compat with v5p.
112112
"pathwaysutils==0.1.2", # For JAX+Pathways single-controller accelerator coordinator.
113113
]
114114
# Vertex AI tensorboard. TODO(markblee): Merge with `gcp`.
@@ -134,7 +134,7 @@ dataflow = [
134134
# GPU custom kernel dependency.
135135
gpu = [
136136
"triton>=2.1.0",
137-
"jax[cuda12]>=0.9.1.dev20260130,<0.9.2",
137+
"jax[cuda12]==0.10.0",
138138
"nvidia-ml-py==12.560.30",
139139
# pin nccl version, otherwise jax[cuda12] will pull latest version
140140
"nvidia-nccl-cu12==2.27.5",

0 commit comments

Comments
 (0)