Skip to content

Commit bda3b4e

Browse files
judyzhaoxinwucamiloCienet
authored andcommitted
chore: revert accidental changes to optimizer.py, state_builder_test.py, trainer.py and fuji-70B txt during rebase
1 parent 4d8a3b0 commit bda3b4e

4 files changed

Lines changed: 6 additions & 13 deletions

File tree

axlearn/common/optimizers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
import typing_extensions
3838
from absl import logging
3939
from jax import numpy as jnp
40+
41+
# from jax._src.sharding_impls import TransferToMemoryKind
4042
from optax._src import numerics
4143

4244
from axlearn.common import flax_struct, schedule

axlearn/common/state_builder_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ def _mock_bert_trainer_config(
293293
embedding_cfg=bert.bert_embedding_config(max_position_embeddings=max_len),
294294
stack_cfg=bert.bert_transformer_config(num_layers=3, num_heads=2),
295295
),
296-
mesh_axis_names=("fsdp", "model"),
297296
)
298297

299298
def _mock_bert_trainer_config_and_state(

axlearn/common/trainer.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ def run(
646646
)
647647
self.vlog(3, "Done step %s", self.step)
648648
num_steps += 1
649-
if num_steps % 1 == 0:
649+
if num_steps % 100 == 0:
650650
now = time.perf_counter()
651651
average_step_time = (now - start_time) / num_steps
652652
self._step_log("Average step time: %s seconds", average_step_time)
@@ -1372,7 +1372,6 @@ def _maybe_stop_or_start_tracing(
13721372
cfg.start_trace_process_indices == "all"
13731373
or jax.process_index() in cfg.start_trace_process_indices
13741374
)
1375-
self._step_log(f"{should_start_tracing=}")
13761375
if should_start_tracing:
13771376
self._step_log("Start profiler tracing")
13781377
profiler_options = jax.profiler.ProfileOptions()

axlearn/experiments/testdata/axlearn.experiments.text.gpt.c4_trainer/fuji-70B-v1-flash-fp8.txt

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ mesh_rules[7][1].config_modifiers[0].mesh_shape[5]: 1
248248
mesh_rules[7][1].config_modifiers[1].fp8_amax_history_length: 128
249249
mesh_rules[7][1].config_modifiers[1].klass: 'axlearn.common.trainer_config_modifier.FP8ConfigModifier'
250250
mesh_rules[7][1].klass: 'axlearn.common.trainer_config_modifier.ChainConfigModifier'
251-
mesh_rules[8][0]: 'gpu-(a4-highgpu-8g|a4x-highgpu-4g)-(256|512|1024)'
251+
mesh_rules[8][0]: 'gpu-(a4-highgpu-8g)-(256|512|1024)'
252252
mesh_rules[8][1].config_modifiers[0].klass: 'axlearn.common.trainer_config_modifier.MeshShapeModifier'
253253
mesh_rules[8][1].config_modifiers[0].mesh_shape[0]: 1
254254
mesh_rules[8][1].config_modifiers[0].mesh_shape[1]: -1
@@ -259,15 +259,8 @@ mesh_rules[8][1].config_modifiers[0].mesh_shape[5]: 1
259259
mesh_rules[8][1].config_modifiers[1].gpu_block_size: 64
260260
mesh_rules[8][1].config_modifiers[1].klass: 'axlearn.common.flash_attention.layer.FlashBlockSizeModifier'
261261
mesh_rules[8][1].config_modifiers[1].tpu_block_size: 512
262-
mesh_rules[8][1].config_modifiers[2].klass: 'axlearn.common.trainer_config_modifier.RematSpecModifier'
263-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['prevent_cse']: False
264-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['policy'].fn: 'axlearn.common.utils.save_and_offload_only_these_names_regex'
265-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['policy'].names_which_can_be_offloaded: '.*input'
266-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['policy'].names_which_can_be_saved: '.*[kqv]_proj'
267-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['policy'].offload_dst: 'pinned_host'
268-
mesh_rules[8][1].config_modifiers[2].remat_policies['model.decoder.transformer.layer']['policy'].offload_src: 'device'
269-
mesh_rules[8][1].config_modifiers[3].fp8_amax_history_length: 128
270-
mesh_rules[8][1].config_modifiers[3].klass: 'axlearn.common.trainer_config_modifier.FP8ConfigModifier'
262+
mesh_rules[8][1].config_modifiers[2].fp8_amax_history_length: 128
263+
mesh_rules[8][1].config_modifiers[2].klass: 'axlearn.common.trainer_config_modifier.FP8ConfigModifier'
271264
mesh_rules[8][1].klass: 'axlearn.common.trainer_config_modifier.ChainConfigModifier'
272265
mesh_rules[9][0]: 'neuron-(trn2|trn2n).48xlarge-64'
273266
mesh_rules[9][1].config_modifiers[0].klass: 'axlearn.common.trainer_config_modifier.MeshShapeModifier'

0 commit comments

Comments
 (0)