Skip to content

Commit 69920a2

Browse files
committed
Support DWS canlendar with regular reservation
1 parent 4aa1576 commit 69920a2

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

  • community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts

community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/resume.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ def instance_properties(nodeset: NSDict, model:str, placement_group:Optional[str
105105
props.resourcePolicies = [placement_group]
106106

107107
if reservation := lookup().nodeset_reservation(nodeset):
108+
108109
update_reservation_props(reservation, props, placement_group, reservation.calendar)
109110

110111
if (fr := lookup().future_reservation(nodeset)) and fr.specific:

community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/test_util.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,8 @@ def test_nodeset_reservation_err(nodeset, err):
198198
policies=[],
199199
deployment_type=None,
200200
reservation_mode=None,
201+
assured_count=None,
202+
delete_at_time=None,
201203
bulk_insert_name="projects/bobin/reservations/robin")),
202204
(TstNodeset(
203205
reservation_name="projects/bobin/reservations/robin",
@@ -210,6 +212,8 @@ def test_nodeset_reservation_err(nodeset, err):
210212
policies=["wanders", "apples", "yum"],
211213
deployment_type=None,
212214
reservation_mode=None,
215+
assured_count=None,
216+
delete_at_time=None,
213217
bulk_insert_name="projects/bobin/reservations/robin")),
214218
(TstNodeset(
215219
reservation_name="projects/bobin/reservations/robin/snek/cheese-brie-6",
@@ -222,6 +226,8 @@ def test_nodeset_reservation_err(nodeset, err):
222226
policies=[],
223227
deployment_type=None,
224228
reservation_mode=None,
229+
assured_count=1,
230+
delete_at_time=None,
225231
bulk_insert_name="projects/bobin/reservations/robin/snek/cheese-brie-6")),
226232
227233
])
@@ -575,7 +581,7 @@ def test_future_reservation_inactive(_):
575581
TstNodeset(future_reservation="projects/manhattan/zones/danger/futureReservations/zebra")) == FutureReservation(
576582
project='manhattan',
577583
zone='danger',
578-
name='zebra',
584+
name='zebra',
579585
specific=True,
580586
start_time=datetime(2025, 1, 27, 23, 30, tzinfo=timezone.utc),
581587
end_time=datetime(2025, 2, 21, 23, 30, tzinfo=timezone.utc),

0 commit comments

Comments
 (0)