Skip to content

Commit 85bb4f8

Browse files
committed
Revert "Merge pull request GoogleCloudPlatform#4739 from kadupoornima/numa-ff"
This reverts commit 721983b, reversing changes made to 4f8b592.
1 parent 00d4c55 commit 85bb4f8

4 files changed

Lines changed: 0 additions & 24 deletions

File tree

examples/gke-g4/gke-g4.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ deployment_groups:
122122
system_node_pool_taints: []
123123
enable_dcgm_monitoring: true
124124
enable_private_endpoint: false # Allows access from authorized public IPs
125-
enable_numa_aware_scheduling: true
126125
configure_workload_identity_sa: true
127126
master_authorized_networks:
128127
- cidr_block: $(vars.authorized_cidr) # Allows your machine to run the kubectl command. Required for multi network setup.

modules/scheduler/gke-cluster/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ limitations under the License.
155155
| <a name="input_enable_master_global_access"></a> [enable\_master\_global\_access](#input\_enable\_master\_global\_access) | Whether the cluster master is accessible globally (from any region) or only within the same region as the private endpoint. | `bool` | `false` | no |
156156
| <a name="input_enable_multi_networking"></a> [enable\_multi\_networking](#input\_enable\_multi\_networking) | Enables [multi networking](https://cloud.google.com/kubernetes-engine/docs/how-to/setup-multinetwork-support-for-pods#create-a-gke-cluster) (Requires GKE Enterprise). This setting is immutable on clusters and enables [Dataplane V2](https://cloud.google.com/kubernetes-engine/docs/concepts/dataplane-v2?hl=en). If null, will determine state based on if additional\_networks are passed in. | `bool` | `null` | no |
157157
| <a name="input_enable_node_local_dns_cache"></a> [enable\_node\_local\_dns\_cache](#input\_enable\_node\_local\_dns\_cache) | Enable GKE NodeLocal DNSCache addon to improve DNS lookup latency | `bool` | `false` | no |
158-
| <a name="input_enable_numa_aware_scheduling"></a> [enable\_numa\_aware\_scheduling](#input\_enable\_numa\_aware\_scheduling) | Enable [NUMA-aware](https://cloud.google.com/kubernetes-engine/distributed-cloud/bare-metal/docs/vm-runtime/numa) scheduling. | `bool` | `false` | no |
159158
| <a name="input_enable_parallelstore_csi"></a> [enable\_parallelstore\_csi](#input\_enable\_parallelstore\_csi) | The status of the Google Compute Engine Parallelstore Container Storage Interface (CSI) driver addon, which allows the usage of a parallelstore as volumes. | `bool` | `false` | no |
160159
| <a name="input_enable_persistent_disk_csi"></a> [enable\_persistent\_disk\_csi](#input\_enable\_persistent\_disk\_csi) | The status of the Google Compute Engine Persistent Disk Container Storage Interface (CSI) driver addon, which allows the usage of a PD as volumes. | `bool` | `true` | no |
161160
| <a name="input_enable_private_endpoint"></a> [enable\_private\_endpoint](#input\_enable\_private\_endpoint) | (Beta) Whether the master's internal IP address is used as the cluster endpoint. | `bool` | `true` | no |

modules/scheduler/gke-cluster/main.tf

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -241,22 +241,6 @@ resource "google_container_cluster" "gke_cluster" {
241241
enable_secure_boot = var.system_node_pool_enable_secure_boot
242242
enable_integrity_monitoring = true
243243
}
244-
245-
kubelet_config {
246-
cpu_manager_policy = var.enable_numa_aware_scheduling ? "static" : null
247-
dynamic "topology_manager" {
248-
for_each = var.enable_numa_aware_scheduling ? [1] : []
249-
content {
250-
policy = "restricted"
251-
}
252-
}
253-
dynamic "memory_manager" {
254-
for_each = var.enable_numa_aware_scheduling ? [1] : []
255-
content {
256-
policy = "Static"
257-
}
258-
}
259-
}
260244
}
261245

262246
control_plane_endpoints_config {

modules/scheduler/gke-cluster/variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,3 @@ variable "enable_external_dns_endpoint" {
525525
type = bool
526526
default = false
527527
}
528-
529-
variable "enable_numa_aware_scheduling" {
530-
description = "Enable [NUMA-aware](https://cloud.google.com/kubernetes-engine/distributed-cloud/bare-metal/docs/vm-runtime/numa) scheduling."
531-
type = bool
532-
default = false
533-
}

0 commit comments

Comments
 (0)