add documentation and cleanup the code

Author: ighosh98

community/modules/management/dependencies-installer/kubernetes_manifest/README.md

@@ -3,7 +3,7 @@
 
 | Name | Version |
 |------|---------|
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.0 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3 |
 | <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | ~> 2.23 |
 
 ## Providers
@@ -29,7 +29,7 @@ No modules.
 | <a name="input_content"></a> [content](#input\_content) | The YAML body to apply to gke cluster. | `string` | `null` | no |
 | <a name="input_field_manager"></a> [field\_manager](#input\_field\_manager) | (Optional) Configure field manager options. The `name` is the name of the field manager. The `force_conflicts` flag allows overriding conflicts. | <pre>object({<br/>    name            = optional(string, null)<br/>    force_conflicts = optional(bool, false)<br/>  })</pre> | `null` | no |
 | <a name="input_resource_timeouts"></a> [resource\_timeouts](#input\_resource\_timeouts) | (Optional) Configure custom timeouts for the create, update, and delete operations of the resource. These timeouts also govern the duration for any 'wait' conditions to be met. | <pre>object({<br/>    create = optional(string, null)<br/>    update = optional(string, null)<br/>    delete = optional(string, null)<br/>  })</pre> | <pre>{<br/>  "create": "15m",<br/>  "delete": "5m",<br/>  "update": "10m"<br/>}</pre> | no |
-| <a name="input_source_path"></a> [source\_path](#input\_source\_path) | The source for manifest(s) to apply to gke cluster. Acceptable sources are a local yaml or template (.tftpl) file path, a directory (ends with '/') containing yaml or template files, and a url for a yaml file. | `string` | `null` | no |
+| <a name="input_source_path"></a> [source\_path](#input\_source\_path) | The source for manifest(s) to apply to gke cluster. Acceptable sources are a local yaml or template (.tftpl) file path, a directory (ends with '/') containing yaml or template files, and a url for a yaml file. | `string` | `""` | no |
 | <a name="input_template_vars"></a> [template\_vars](#input\_template\_vars) | The values to populate template file(s) with. | `any` | `null` | no |
 | <a name="input_wait_for_fields"></a> [wait\_for\_fields](#input\_wait\_for\_fields) | (Optional) A map of attribute paths and desired patterns to be matched. After each apply the provider will wait for all attributes listed here to reach a value that matches the desired pattern. | `map(string)` | `{}` | no |
 | <a name="input_wait_for_rollout"></a> [wait\_for\_rollout](#input\_wait\_for\_rollout) | Wait or not for Deployments and APIService to complete rollout. See [kubectl wait](https://kubernetes.io/docs/reference/kubectl/generated/kubectl_wait/) for more details. | `bool` | `true` | no |

community/modules/management/dependencies-installer/kubernetes_manifest/main.tf

@@ -19,24 +19,21 @@ locals {
   # Prioritize 'content' variable if provided
   primary_content_body = var.content != "" ? var.content : null
 
-  # Prepare a null-safe version of var.source_path for conditional checks
-  null_safe_source_path = coalesce(var.source_path, "")
-
   # --- 2. Handle 'source_path' based on its type (File vs. Directory) ---
 
   # Check if source_path is a directory (indicated by trailing slash)
-  is_directory            = endswith(local.null_safe_source_path, "/")
-  directory_absolute_path = local.is_directory ? abspath(local.null_safe_source_path) : null
+  is_directory            = endswith(var.source_path, "/")
+  directory_absolute_path = local.is_directory ? abspath(var.source_path) : null
 
   # Check if source_path is a single yaml or tftpl file (only if not a directory)
   is_single_file = !local.is_directory && (
-    length(regexall("\\.yaml$", lower(local.null_safe_source_path))) > 0 ||
-    length(regexall("\\.tftpl$", lower(local.null_safe_source_path))) > 0
+    length(regexall("\\.yaml$", lower(var.source_path))) > 0 ||
+    length(regexall("\\.tftpl$", lower(var.source_path))) > 0
   )
   single_file_raw_content = local.is_single_file ? (
-    length(regexall("\\.tftpl$", lower(local.null_safe_source_path))) > 0 ?
-    templatefile(abspath(local.null_safe_source_path), var.template_vars) :
-    file(abspath(local.null_safe_source_path))
+    length(regexall("\\.tftpl$", lower(var.source_path))) > 0 ?
+    templatefile(abspath(var.source_path), var.template_vars) :
+    file(abspath(var.source_path))
   ) : null
 
   # Docs from primary_content_body
@@ -78,8 +75,6 @@ locals {
   })
 }
 
-
-
 # Apply all manifest files dynamically
 resource "kubernetes_manifest" "apply_manifests" {
   for_each = local.docs_map
@@ -106,5 +101,4 @@ resource "kubernetes_manifest" "apply_manifests" {
       force_conflicts = field_manager.value.force_conflicts
     }
   }
-
 }

community/modules/management/dependencies-installer/kubernetes_manifest/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2024 "Google LLC"
+# Copyright 2025 "Google LLC"
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

community/modules/management/dependencies-installer/kubernetes_manifest/variables.tf

@@ -23,7 +23,7 @@ variable "content" {
 variable "source_path" {
   description = "The source for manifest(s) to apply to gke cluster. Acceptable sources are a local yaml or template (.tftpl) file path, a directory (ends with '/') containing yaml or template files, and a url for a yaml file."
   type        = string
-  default     = null
+  default     = ""
 }
 
 variable "template_vars" {

community/modules/management/dependencies-installer/kubernetes_manifest/versions.tf

@@ -13,12 +13,12 @@
 # limitations under the License.
 
 terraform {
-  required_version = ">= 1.0.0"
   # Defines the providers that this module depends on and their versions.
   required_providers {
     kubernetes = {
       source  = "hashicorp/kubernetes"
-      version = "~> 2.23" #
+      version = "~> 2.23"
     }
   }
+  required_version = ">= 1.3"
 }