Skip to content

Commit 067c33b

Browse files
authored
Migrate the test_owner.py to store the github usernames. (GoogleCloudPlatform#801)
* Update a few DAGs to enable alert plugin Convert abbreviation names in test_owner.py into GitHub username as much as possible * remove tags mechanism * update test owner github username * extract 'airflow' to test_owner.py * revert test owners who has quitted * revert 'Rohan' * add Rohan's username
1 parent dd5a8f7 commit 067c33b

2 files changed

Lines changed: 42 additions & 31 deletions

File tree

dags/common/test_owner.py

Lines changed: 39 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
"""The file of test owners."""
15+
"""
16+
This file is used to look up the GitHub username of a test owner.
17+
18+
The GitHub username is then used to assign the GitHub Issue created by the alert plugin.
19+
20+
Please append your GitHub username if you need to add your test owner item.
21+
"""
1622

1723
import enum
1824

@@ -30,64 +36,67 @@ class Team(enum.Enum):
3036
PRODUCTIVITY = "productivity"
3137

3238

39+
# Default test owner
40+
AIRFLOW = "airflow"
3341
# XLML - TensorFlow
3442
ERIC_L = "Eric L."
35-
CHANDRA_D = "Chandra D."
36-
GAGIK_A = "Gagik A."
43+
CHANDRA_D = "chandrasekhard2"
44+
GAGIK_A = "gagika"
3745

3846
# PYTORCH
3947
PEI_Z = "Pei Z."
40-
MANFEI_B = "Manfei B."
48+
MANFEI_B = "manfeiBai"
4149

4250
# MaxText
43-
TONY_C = "Tony C."
51+
TONY_C = "tonyjohnchen"
4452
JON_B = "Jon B."
4553
RAYMOND_Z = "Raymond Z."
46-
MATT_D = "Matt D."
54+
MATT_D = "gobbleturk"
4755
PRIYANKA_G = "Priyanka G."
48-
SURBHI_J = "Surbhi J."
56+
SURBHI_J = "SurbhiJainUSC"
4957
ZHIYU_L = "Zhiyu L."
50-
MOHIT_K = "Mohit K."
51-
ANISHA_M = "Anisha M."
58+
MOHIT_K = "khatwanimohit"
59+
ANISHA_M = "A9isha"
5260
YUWEI_Y = "Yuwei Y."
53-
RISHABH_B = "Rishabh B."
54-
NUOJIN_C = "Nuojin C."
61+
RISHABH_B = "notabee"
62+
NUOJIN_C = "NuojCheng"
63+
BRANDEN_V = "bvandermoon"
5564

5665
# Multi-tier Checkpointing
57-
ABHINAV_S = "ABHINAV S."
58-
XUEFENG_G = "XUEFENG G."
66+
ABHINAV_S = "abhinavclemson"
67+
XUEFENG_G = "xuefgu"
5968

6069
# MLCompass
61-
ORTI_B = "Orti B."
70+
ORTI_B = "ortibazar"
6271

6372
# Sparsity & Diffusion DevX
64-
RAN_R = "Ran R."
65-
PARAM_B = "Param B."
66-
KUNJAN_P = "Kunjan P."
67-
MICHELLE_Y = "Michelle Y."
68-
SHUNING_J = "Shuning J."
69-
ROHAN_B = "Rohan B."
73+
RAN_R = "RissyRan"
74+
PARAM_B = "parambole"
75+
KUNJAN_P = "coolkp"
76+
MICHELLE_Y = "michelle-yooh"
77+
SHUNING_J = "shuningjin"
78+
ROHAN_B = "Rohan-Bierneni"
7079

7180
# Inference
7281
ANDY_Y = "Andy Y."
73-
XIANG_S = "Xiang S."
82+
XIANG_S = "sixiang-google"
7483
MORGAN_D = "Morgan D."
75-
YIJIA_J = "Yijia J."
76-
PATE_M = "Pate M."
84+
YIJIA_J = "jyj0w0"
85+
PATE_M = "patemotter"
7786

7887
# 3P Ecosystems
79-
RICHARD_L = "Richard L."
80-
WENXIN_D = "Wenxin D."
88+
RICHARD_L = "richardsliu"
89+
WENXIN_D = "wenxindongwork"
8190

8291
# FRAMEWORK
83-
QINY_Y = "Qinyi Y."
92+
QINY_Y = "qinyiyan"
8493

8594
# JAX
86-
AKANKSHA_G = "Akanksha G."
95+
AKANKSHA_G = "guptaaka"
8796

8897
# MAP_REPRODUCIBILITY
89-
GUNJAN_J = "Gunjan J."
98+
GUNJAN_J = "gunjanj007"
9099

91100
# Bite
92-
Maggie_Z = "Maggie Z."
93-
Andrew_S = "Andrew S."
101+
Maggie_Z = "jiya-zhang"
102+
Andrew_S = "asall"

dags/examples/always_fail.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
from airflow.exceptions import AirflowException
77
from airflow.utils.task_group import TaskGroup
88

9+
from dags.common import test_owner
10+
911
"""
1012
A DAG that always fails when triggered. This DAG is an example DAG used to
1113
trigger the on_failure_actions.py/DagRunListener plugin and post a Github
@@ -19,7 +21,7 @@ def task_a():
1921

2022

2123
# Add or override the owner of the task, in order to assign issue assignees.
22-
@task(owner="airflow")
24+
@task(owner=test_owner.AIRFLOW)
2325
def task_b():
2426
logging.info("task B")
2527
raise AirflowException("task B failed")

0 commit comments

Comments
 (0)