Skip to content

Commit 64fa140

Browse files
authored
fix: Update cluster names to differentiate between production and development environments (GoogleCloudPlatform#1062)
This change switches the following DAGs to a dedicated, production-isolated cluster to prevent development activity from interfering with test results: - `gke_node_pool_status` - `multi-host-availability-rollback` - `tpu_info_format_validation_dag` - `gke_node_pool_label_update`
1 parent 9e87e69 commit 64fa140

5 files changed

Lines changed: 20 additions & 14 deletions

File tree

dags/tpu_observability/multi_host_nodepool_rollback_dag.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from airflow.utils.task_group import TaskGroup
2525
from airflow.utils.trigger_rule import TriggerRule
2626

27+
from dags import composer_env
2728
from dags.map_reproducibility.utils import constants
2829
from dags.common.vm_resource import Region, Zone
2930
from dags.tpu_observability.utils import node_pool_util as node_pool
@@ -72,11 +73,11 @@
7273
) as dag:
7374
for machine in MachineConfigMap:
7475
config = machine.value
76+
cluster_name = "tpu-observability-automation"
77+
cluster_name += "-prod" if composer_env.is_prod_env() else "-dev"
7578
node_pool_info = node_pool.Info(
7679
project_id="cienet-cmcs",
77-
cluster_name=Variable.get(
78-
"CLUSTER_NAME", default_var="tpu-observability-automation"
79-
),
80+
cluster_name=cluster_name,
8081
node_pool_name=Variable.get(
8182
"NODE_POOL_NAME", default_var="multi-host-nodepool-rollback-auto"
8283
),

dags/tpu_observability/node_pool_status.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from airflow.utils.trigger_rule import TriggerRule
2222
from airflow.utils.task_group import TaskGroup
2323

24+
from dags import composer_env
2425
from dags.map_reproducibility.utils import constants
2526
from dags.common.vm_resource import Region, Zone
2627
from dags.tpu_observability.utils import node_pool_util as node_pool
@@ -60,11 +61,11 @@
6061
) as dag:
6162
for machine in MachineConfigMap:
6263
config = machine.value
64+
cluster_name = "tpu-observability-automation"
65+
cluster_name += "-prod" if composer_env.is_prod_env() else "-dev"
6366
node_pool_info = node_pool.Info(
6467
project_id=models.Variable.get("PROJECT_ID", default_var="cienet-cmcs"),
65-
cluster_name=models.Variable.get(
66-
"CLUSTER_NAME", default_var="tpu-observability-automation"
67-
),
68+
cluster_name=cluster_name,
6869
node_pool_name=models.Variable.get(
6970
"NODE_POOL_NAME", default_var="node-pool-status-v6e-autotest"
7071
),

dags/tpu_observability/tpu_info_format_validation_dags.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
from airflow.exceptions import AirflowFailException
3030
from airflow.utils.task_group import TaskGroup
3131
from airflow.utils.trigger_rule import TriggerRule
32+
33+
from dags import composer_env
3234
from dags.common.vm_resource import Region, Zone
3335
from dags.map_reproducibility.utils import constants
3436
from dags.tpu_observability.configs.common import MachineConfigMap, TpuConfig
@@ -324,13 +326,13 @@ def validate_latency_table(tpu_info_output: list[tpu_info.Table]):
324326
) as dag:
325327
for machine in MachineConfigMap:
326328
config = machine.value
329+
cluster_name = "tpu-observability-automation"
330+
cluster_name += "-prod" if composer_env.is_prod_env() else "-dev"
327331
cluster_info = node_pool.Info(
328332
project_id=models.Variable.get(
329333
"TFV_PROJECT_ID", default_var="cienet-cmcs"
330334
),
331-
cluster_name=models.Variable.get(
332-
"TFV_CLUSTER_NAME", default_var="tpu-observability-automation"
333-
),
335+
cluster_name=cluster_name,
334336
node_pool_name=models.Variable.get(
335337
"TFV_NODE_POOL_NAME", default_var="tpu-info-fromat-test-v6e"
336338
),

dags/tpu_observability/update_node_pool_label.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
from airflow import models
2222
from airflow.utils.task_group import TaskGroup
2323
from airflow.utils.trigger_rule import TriggerRule
24+
25+
from dags import composer_env
2426
from dags.common.vm_resource import Region, Zone
2527
from dags.map_reproducibility.utils import constants
2628
from dags.tpu_observability.configs.common import MachineConfigMap
@@ -57,11 +59,11 @@
5759
) as dag:
5860
for machine in MachineConfigMap:
5961
config = machine.value
62+
cluster_name = "tpu-observability-automation"
63+
cluster_name += "-prod" if composer_env.is_prod_env() else "-dev"
6064
node_pool_info = node_pool.Info(
6165
project_id="cienet-cmcs",
62-
cluster_name=models.Variable.get(
63-
"CLUSTER_NAME", default_var="tpu-observability-automation"
64-
),
66+
cluster_name=cluster_name,
6567
node_pool_name=models.Variable.get(
6668
"NODE_POOL_NAME", default_var="update-node-pool-label-v6e-autotest"
6769
),

dags/tpu_observability/utils/node_pool_util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ def create(
8282

8383
composer.log_metadata_for_xlml_dashboard({
8484
"cluster_project": node_pool.project_id,
85-
"region": node_pool.region,
86-
"zone": node_pool.zone,
85+
"region": node_pool.location,
86+
"zone": node_pool.node_locations,
8787
"cluster_name": node_pool.cluster_name,
8888
"node_pool_name": node_pool.node_pool_name,
8989
"accelerator_type": node_pool.machine_type,

0 commit comments

Comments
 (0)