Skip to content

Commit d58657c

Browse files
authored
fix: Rename Pathways elastic DAGs (GoogleCloudPlatform#1295)
Rename the following DAGs: - `pw_mcjax_benchmark_recipe_elastic` to `pw_elastic_pause_resume` - `pw_mcjax_benchmark_recipe_elastic_Replica-resize` ro `pw_elastic_replica_resize`
1 parent 0cedac5 commit d58657c

3 files changed

Lines changed: 4 additions & 18 deletions

File tree

.github/workflows/dag-check.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ jobs:
4343
- name: Install Python dependencies
4444
run: pip install -r .github/requirements.txt
4545

46-
- name: Authenticate with gcloud
47-
uses: google-github-actions/auth@v2
48-
with:
49-
credentials_json: ${{ secrets.GCS_SECRET }}
50-
create_credentials_file: true
51-
5246
- name: Run DAGs
5347
run: |
5448
scripts/dag-check.sh

dags/common/scheduling_helper/scheduling_helper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ class DayOfWeek(enum.Enum):
9393
},
9494
PW_MCJAX_CLUSTER.name: {
9595
"pw_mcjax_benchmark_recipe": DefaultTimeout,
96-
"pw_mcjax_benchmark_recipe_elastic": DefaultTimeout,
97-
"pw_mcjax_benchmark_recipe_elastic_Replica-resize": DefaultTimeout,
96+
"pw_elastic_pause_resume": DefaultTimeout,
97+
"pw_elastic_replica_resize": DefaultTimeout,
9898
},
9999
}
100100

dags/maxtext_pathways/pw_mcjax_elastic.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ def worker_pod_interruption(
403403

404404
RECIPE_INSTANCE = recipe_cfg.Recipe.PW_MCJAX_BENCHMARK_RECIPE
405405
RECIPE_NAME = RECIPE_INSTANCE.value.lower()
406-
DAG_ID = f"{RECIPE_NAME}_elastic"
406+
DAG_ID = "pw_elastic_pause_resume"
407407
SCHEDULE = SchedulingHelper.arrange_schedule_time(DAG_ID)
408408

409409
with models.DAG(
@@ -531,17 +531,9 @@ def worker_pod_interruption(
531531
title="Number Slices",
532532
description="Number of slices",
533533
),
534-
"runner": ui_params.Param(
535-
# TODO(cienet): Replace with an official or production-ready image
536-
# TODO(cienet): Use an image tag instead of the full SHA hash
537-
"gcr.io/cloud-tpu-multipod-dev/lidanny_rr_dag@sha256:08dfca25461e3f2fb736e7313a742e1ceea6123858c0aec5dfe43d0c51d14e38",
538-
type="string",
539-
title="Runner Image",
540-
description="Runner image for the cluster",
541-
),
542534
})
543535

544-
DAG_ID_RESIZE = f"{RECIPE_NAME}_elastic_{ELASTIC_TYPE[1]}"
536+
DAG_ID_RESIZE = "pw_elastic_replica_resize"
545537
SCHEDULE_RESIZE = SchedulingHelper.arrange_schedule_time(DAG_ID_RESIZE)
546538

547539
with models.DAG(

0 commit comments

Comments
 (0)