Skip to content

Commit fa30f23

Browse files
authored
fix removing --skip_validation with xpk verison is v0.4.1 (GoogleCloudPlatform#1076)
1 parent e33009c commit fa30f23

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

xlml/utils/xpk.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ def run_workload(
140140
f" --{multi_keyword}={num_slices} --docker-image={docker_image}"
141141
f" --project={cluster_project} --zone={zone}"
142142
f" --env {metric_config.SshEnvVars.GCS_OUTPUT.name}={gcs_path}"
143-
f" --skip-validation"
144143
)
145144

146145
if ramdisk_directory and not use_pathways:
@@ -159,6 +158,10 @@ def run_workload(
159158
# then branch is switch to "v0.4.1".
160159
if is_valid_gpu_version(accelerator_type) and xpk_branch == MAIN_BRANCH:
161160
xpk_branch = "v0.4.1"
161+
# "v0.4.1" doesn't support the "--skip_validation" parameter, ignore.
162+
else:
163+
# Default parameter to skip validation procedure.
164+
workload_create_cmd += " --skip-validation"
162165

163166
cmds = get_xpk_setup_cmd(tmpdir, xpk_branch)
164167
if accelerator_type == GpuVersion.XPK_H100_MEGA.value:

0 commit comments

Comments
 (0)