Skip to content

Commit 04e1f25

Browse files
committed
Apply the changes to the affected DAGs
1 parent d9e0ed0 commit 04e1f25

5 files changed

Lines changed: 16 additions & 12 deletions

dags/examples/maxtext_profile_sweep_example_dag.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
"""
1616
An example DAG to extract profile metrics from pretraining mixtral-8x7b model on v6-256.
17-
Profile extraction can be seamlessly integrated with maxtext_sweep_gke_config + run_with_name_gen_and_quarantine.
17+
Profile extraction can be seamlessly integrated with maxtext_sweep_gke_config + (to_name_gen_and_quarantine_task + run).
1818
"""
1919

2020
import datetime
@@ -142,4 +142,4 @@ def dict_to_arg(param_dict):
142142
)
143143

144144
for test in maxtext_sweep_gke_test:
145-
test.run_with_name_gen_and_quarantine(quarantine_task_group)
145+
test.to_name_gen_and_quarantine_task(quarantine_task_group).run()

dags/orbax/maxtext_emc_restore_gcs.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,13 @@
128128
run_model_cmds=workload_command,
129129
docker_image=image.value,
130130
test_owner=test_owner.DEPP_L,
131-
).run_with_node_interruption(
131+
).to_node_interruption_task(
132+
expect_reach_to_step=step_to_interrupt,
133+
last_node=True,
134+
).run(
132135
ramdisk_directory=test_config_util.DEFAULT_RAM_DISK,
133136
mtc_enabled=True,
134137
skip_post_process=True,
135-
last_node=True,
136-
expect_reach_to_step=step_to_interrupt,
137138
max_restart=15,
138139
)
139140

dags/orbax/maxtext_emc_restore_local.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,12 @@
126126
run_model_cmds=workload_command,
127127
docker_image=image.value,
128128
test_owner=test_owner.DEPP_L,
129-
).run_with_node_interruption(
129+
).to_node_interruption_task(
130+
expect_reach_to_step=step_to_interrupt,
131+
).run(
130132
ramdisk_directory=test_config_util.DEFAULT_RAM_DISK,
131133
mtc_enabled=True,
132134
skip_post_process=True,
133-
expect_reach_to_step=step_to_interrupt,
134135
max_restart=15,
135136
)
136137

dags/orbax/maxtext_mtc_restore_local.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,12 @@
129129
run_model_cmds=workload_command,
130130
docker_image=image.value,
131131
test_owner=test_owner.DEPP_L,
132-
).run_with_node_interruption(
132+
).to_node_interruption_task(
133+
expect_reach_to_step=step_to_interrupt,
134+
).run(
133135
ramdisk_directory=test_config_util.DEFAULT_RAM_DISK,
134136
mtc_enabled=True,
135137
skip_post_process=True,
136-
expect_reach_to_step=step_to_interrupt,
137138
max_restart=15,
138139
)
139140

dags/orbax/maxtext_reg_restore_gcs_with_node_disruption.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,13 +138,14 @@ def generate_workload_checkpoints_location(gcs_ckpt_location: str) -> str:
138138
run_model_cmds=workload_command,
139139
docker_image=image.value,
140140
test_owner=test_owner.SHARON_Y,
141-
).run_with_node_interruption(
141+
).to_node_interruption_task(
142+
expect_reach_to_step=step_to_interrupt,
143+
check_file_exists=True,
144+
).run(
142145
gcs_location=gcs_location,
143146
xpk_branch=MAIN_BRANCH,
144147
skip_post_process=True,
145-
expect_reach_to_step=step_to_interrupt,
146148
max_restart=15,
147-
check_file_exists=True,
148149
)
149150

150151
end_time = validation_util.generate_timestamp.override(

0 commit comments

Comments
 (0)