Skip to content

Commit 846aa8d

Browse files
authored
fix: Update the image for maxtext_gpu_end_to_end (GoogleCloudPlatform#1117)
This change updates the Docker image used by the `maxtext_gpu_end_to_end` DAG to align with changes in the MaxText repository.
1 parent cc6fe76 commit 846aa8d

5 files changed

Lines changed: 12 additions & 22 deletions

File tree

dags/common/vm_resource.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -368,20 +368,12 @@ class DockerImage(enum.Enum):
368368
"gcr.io/tpu-prod-env-multipod/maxdiffusion_stable_stack_candidate:"
369369
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
370370
)
371-
MAXTEXT_GPU_JAX_STABLE_STACK = (
372-
"gcr.io/tpu-prod-env-multipod/maxtext_gpu_jax_stable_stack:"
373-
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
374-
)
375371
MAXTEXT_GPU_JAX_STABLE = (
376372
"gcr.io/tpu-prod-env-multipod/maxtext_gpu_jax_stable:"
377373
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
378374
)
379-
MAXTEXT_GPU_STABLE_STACK_NIGHTLY_JAX = (
380-
"gcr.io/tpu-prod-env-multipod/maxtext_gpu_stable_stack_nightly_jax:"
381-
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
382-
)
383-
MAXTEXT_GPU_JAX_AI_CANDIDATE_IMAGE = (
384-
"gcr.io/tpu-prod-env-multipod/maxtext_stable_stack_candidate_gpu:"
375+
MAXTEXT_GPU_JAX_NIGHTLY = (
376+
"gcr.io/tpu-prod-env-multipod/maxtext_gpu_jax_nightly:"
385377
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"
386378
)
387379
CLOUD_HYBRIDSIM_NIGHTLY = (

dags/multipod/maxtext_configs_aot_gpu.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
from airflow.utils.task_group import TaskGroup
2121
from dags import composer_env
2222
from dags.common import test_owner
23-
from dags.common.vm_resource import GpuVersion, TpuVersion, Zone, DockerImage, XpkClusters
23+
from dags.common.vm_resource import DockerImage, XpkClusters
2424
from dags.multipod.configs import gke_config
25-
from dags.multipod.configs.common import SetupMode
2625

2726
# Run once a day at 5 am UTC (9 pm PST / 10 pm PDT)
2827
SCHEDULED_TIME = "45 4 * * *" if composer_env.is_prod_env() else None
@@ -56,6 +55,6 @@
5655
run_model_cmds=(cmd,),
5756
num_slices=1,
5857
cluster=XpkClusters.GPU_A3PLUS_CLUSTER,
59-
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE_STACK.value,
58+
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE.value,
6059
test_owner=test_owner.NUOJIN_C,
6160
).run_with_quarantine(quarantine_task_group)

dags/multipod/maxtext_gpu_end_to_end.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from airflow.utils.task_group import TaskGroup
2525
from dags import composer_env
2626
from dags.common import test_owner
27-
from dags.common.vm_resource import XpkClusters, CpuVersion, DockerImage, GpuVersion, Project, TpuVersion, Zone
27+
from dags.common.vm_resource import XpkClusters, DockerImage, Project
2828
from dags.multipod.configs import gke_config
2929
from xlml.utils import gke
3030

@@ -206,7 +206,7 @@ def run_maxtext_tests(dag: models.DAG):
206206
run_model_cmds=(test_script,),
207207
num_slices=nnodes,
208208
cluster=XpkClusters.GPU_A3_CLUSTER,
209-
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE_STACK.value,
209+
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE.value,
210210
test_owner=test_owner.ANISHA_M,
211211
).run_with_quarantine(quarantine_task_group)
212212
stable_a3plus_gpu = gke_config.get_maxtext_end_to_end_gpu_gke_test_config(
@@ -215,7 +215,7 @@ def run_maxtext_tests(dag: models.DAG):
215215
run_model_cmds=(test_script,),
216216
num_slices=nnodes,
217217
cluster=XpkClusters.GPU_A3PLUS_CLUSTER,
218-
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE_STACK.value,
218+
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE.value,
219219
test_owner=test_owner.ANISHA_M,
220220
).run_with_quarantine(quarantine_task_group)
221221
stable_a3_gpu >> stable_a3plus_gpu

dags/sparsity_diffusion_devx/jax_ai_image_gpu_e2e.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,11 @@
1717

1818
import datetime
1919
from airflow import models
20-
from dags import composer_env, gcs_bucket
20+
from dags import composer_env
2121
from dags.common import test_owner
22-
from dags.common.vm_resource import Project, TpuVersion, CpuVersion, Zone, DockerImage, GpuVersion, XpkClusters
22+
from dags.common.vm_resource import DockerImage, XpkClusters
2323
from airflow.utils.task_group import TaskGroup
2424
from dags.sparsity_diffusion_devx.configs import gke_config as config
25-
from xlml.utils import name_format
2625
from dags.multipod.configs.common import SetupMode
2726

2827
# Run once a day at 7 am UTC (11 pm PST)
@@ -70,7 +69,7 @@
7069
)
7170

7271
docker_images = [
73-
(SetupMode.NIGHTLY, DockerImage.MAXTEXT_GPU_STABLE_STACK_NIGHTLY_JAX),
72+
(SetupMode.NIGHTLY, DockerImage.MAXTEXT_GPU_JAX_NIGHTLY),
7473
]
7574

7675
for model, (test_script, nnodes) in test_models_gpu.items():

dags/sparsity_diffusion_devx/maxtext_moe_gpu_e2e.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def run_maxtext_tests():
6363
run_model_cmds=(test_script,),
6464
num_slices=nnodes,
6565
cluster=XpkClusters.GPU_A3PLUS_CLUSTER,
66-
docker_image=DockerImage.MAXTEXT_GPU_JAX_AI_CANDIDATE_IMAGE.value,
66+
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE.value,
6767
test_owner=test_owner.MICHELLE_Y,
6868
).run_with_quarantine(quarantine_task_group)
6969
)
@@ -73,7 +73,7 @@ def run_maxtext_tests():
7373
run_model_cmds=(test_script,),
7474
num_slices=nnodes,
7575
cluster=XpkClusters.GPU_A3PLUS_CLUSTER,
76-
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE_STACK.value,
76+
docker_image=DockerImage.MAXTEXT_GPU_JAX_STABLE.value,
7777
test_owner=test_owner.MICHELLE_Y,
7878
).run_with_quarantine(quarantine_task_group)
7979
candidate_a3plus_gpu >> stable_a3plus_gpu

0 commit comments

Comments
 (0)