Skip to content

Commit b9c513a

Browse files
authored
fix: Resolve DAG validation errors triggered by unexpected log output from the pod_pattern regex (GoogleCloudPlatform#1154)
Resolve DAG validation errors triggered by unexpected log output from the pod_pattern regex
1 parent a8bb2af commit b9c513a

6 files changed

Lines changed: 6 additions & 6 deletions

dags/orbax/maxtext_emc_resume_gcs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@
205205
project_id=test_config.cluster.project,
206206
location=zone_to_region(test_config.cluster.zone),
207207
cluster_name=test_config.cluster.name,
208-
pod_pattern="max.*-job-0-0",
208+
pod_pattern=f"{test_config.short_id}.*-job-0-0",
209209
interrupt_at_step=first_training_step - 1,
210210
start_time=start_time,
211211
end_time=end_time,

dags/orbax/maxtext_emc_save_gcs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
workload_command = test_config.generate_workload_command(
101101
checkpoint_dir=test_config_util.DEFAULT_RAM_DISK,
102102
run_name=run_name,
103-
out_folder=f"maxtext_emc_orbax_save_gcs",
103+
out_folder="maxtext_emc_orbax_save_gcs",
104104
enable_multi_tier_checkpointing=checkpointing.enable_multi_tier_checkpointing,
105105
slice_num=slice_num,
106106
)

dags/orbax/maxtext_mtc_resume_gcs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@
202202
project_id=test_config.cluster.project,
203203
location=zone_to_region(test_config.cluster.zone),
204204
cluster_name=test_config.cluster.name,
205-
pod_pattern="max.*-job-0-0",
205+
pod_pattern=f"{test_config.short_id}.*-job-0-0",
206206
interrupt_at_step=local_checkpoint_period,
207207
check_last_two_local_saves=False,
208208
start_time=start_time,

dags/orbax/maxtext_mtc_save_gcs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
checkpoint_dir=test_config_util.DEFAULT_RAM_DISK,
104104
run_name=run_name,
105105
slice_num=slice_num,
106-
out_folder=f"maxtext_mtc_orbax_save_gcs",
106+
out_folder="maxtext_mtc_orbax_save_gcs",
107107
enable_multi_tier_checkpointing=checkpointing.enable_multi_tier_checkpointing,
108108
)
109109

dags/orbax/maxtext_reg_restore_gcs_with_node_disruption.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def generate_workload_checkpoints_location(gcs_ckpt_location: str) -> str:
149149
project_id=test_config.cluster.project,
150150
location=zone_to_region(test_config.cluster.zone),
151151
cluster_name=test_config.cluster.name,
152-
pod_pattern=".*0-0",
152+
pod_pattern=f"{test_config.short_id}.*0-0",
153153
interrupt_at_step=step_to_interrupt,
154154
start_time=start_time,
155155
end_time=end_time,

dags/orbax/maxtext_reg_restore_gcs_with_resumed_workload.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
project_id=test_config.cluster.project,
159159
location=zone_to_region(test_config.cluster.zone),
160160
cluster_name=test_config.cluster.name,
161-
pod_pattern="max.*-job-0-0",
161+
pod_pattern=f"{test_config.short_id}.*-job-0-0",
162162
interrupt_at_step=initial_step - 1,
163163
start_time=start_time,
164164
end_time=end_time,

0 commit comments

Comments
 (0)