Skip to content

Commit ffc2f25

Browse files
authored
fix: Remove outdated tests in maxtext_trillium_configs_perf (GoogleCloudPlatform#1257)
Remove outdated tests in `maxtext_trillium_configs_perf` Reference: b/498829446#comment2 FIX: b/498829446
1 parent e3c5095 commit ffc2f25

3 files changed

Lines changed: 0 additions & 11 deletions

File tree

dags/common/vm_resource.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,9 +390,6 @@ class DockerImage(enum.Enum):
390390
MICROBENCH_NIGHTLY = (
391391
"gcr.io/tpu-prod-env-one-vm/microbenchmarks_runner:latest"
392392
)
393-
MAXTEXT_JAX_052_RECIPES_012 = (
394-
"gcr.io/tpu-prod-env-multipod/maxtext_tpu_recipes:jax0.5.2-recipes0.1.2"
395-
)
396393
MAXTEXT_POST_TRAINING_STABLE = (
397394
"gcr.io/tpu-prod-env-multipod/maxtext_post_training_stable:"
398395
f"{datetime.datetime.today().strftime('%Y-%m-%d')}"

dags/multipod/configs/common.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class SetupMode(enum.Enum):
2424
STABLE = "stable"
2525
NIGHTLY = "nightly"
2626
JAX_STABLE_STACK = "jax_stable_stack"
27-
TPU_RECIPES = "tpu_recipes"
2827

2928

3029
class Platform(enum.Enum):

dags/multipod/maxtext_trillium_configs_perf.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
DOCKER_IMAGES = [
3434
(SetupMode.STABLE, DockerImage.MAXTEXT_TPU_JAX_STABLE),
3535
(SetupMode.NIGHTLY, DockerImage.MAXTEXT_TPU_JAX_NIGHTLY),
36-
(SetupMode.TPU_RECIPES, DockerImage.MAXTEXT_JAX_052_RECIPES_012),
3736
]
3837
BASE_OUTPUT_DIRECTORY = "gs://runner-maxtext-logs"
3938

@@ -71,12 +70,6 @@
7170
all_tests: list[task.XpkTask] = []
7271
for mode, image in DOCKER_IMAGES:
7372
for model in MaxTextTrilliumModelConfigs:
74-
# No tpu-recipe for DeepSeek v3
75-
if (
76-
model == MaxTextTrilliumModelConfigs.DEEPSEEK_V3_EP16
77-
and image == DockerImage.MAXTEXT_JAX_052_RECIPES_012
78-
):
79-
continue
8073
if (
8174
model in need_stable_candidate_set
8275
and image == DockerImage.MAXTEXT_TPU_JAX_STABLE

0 commit comments

Comments
 (0)