feat: Implement strict serial execution - #142
Open
AidenYu1673 wants to merge 3 commits into
Open
Conversation
AidenYu1673
requested review from
alfredyu-cienet,
andrewyct,
severus-ho and
xibinliu
as code owners
December 10, 2025 07:34
alfredyu-cienet
force-pushed
the
maxtext/dev
branch
from
December 17, 2025 01:23
e2f0b81 to
0eff967
Compare
alfredyu-cienet
force-pushed
the
maxtext/user/aiden/fix-maxtext-moe-tpu-e2e
branch
from
December 17, 2025 06:40
d517ee8 to
ce58cb5
Compare
alfredyu-cienet
force-pushed
the
maxtext/dev
branch
from
December 19, 2025 09:46
0eff967 to
6c927eb
Compare
alfredyu-cienet
force-pushed
the
maxtext/dev
branch
from
December 26, 2025 06:36
6c927eb to
e3ed9e3
Compare
alfredyu-cienet
force-pushed
the
maxtext/dev
branch
from
January 5, 2026 07:05
e3ed9e3 to
846aa8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enforce that the generate_gcs_location task must be completed before the entry points of the CPU/TPU Task Groups are allowed to start. This specifically addresses and prevents the nested generate_workload_id task from running prematurely.
Tests
maxtext_moe_tpu_e2e_PR3
Checklist
Before submitting this PR, please make sure (put X in square brackets):