Add TPU Observability validation for help, version, and process monitoring - #165
Add TPU Observability validation for help, version, and process monitoring#165chengpinglin wants to merge 21 commits into
Conversation
ryanliuCienet
left a comment
There was a problem hiding this comment.
Consider combining the three _get_tpu_XXX functions into one, as they are nearly identical.
Regarding task_id, try to maintain consistency. In other words, either provide a task_id for all tasks, or only for those that might be easily confused (e.g., if multiple tasks share the same function, or the function name isn't descriptive enough).
|
done. |
5e1a734 to
34c3ce0
Compare
|
Overall LGTM, wait for @alfredyu-cienet to do the final review. |
0e56073 to
4ccf631
Compare
4ccf631 to
f3c43bc
Compare
alfredyu-cienet
left a comment
There was a problem hiding this comment.
let's migrate to dags/tpu_observability/tpu_info_format_validation_dags.py
--> add the second with models.DAG(...) block in the same file
There was a problem hiding this comment.
I supposed this file is no longer needed?
a65daa4 to
eb88c98
Compare
1c93601 to
1ef36b1
Compare
eb88c98 to
8719639
Compare
alfredyu-cienet
left a comment
There was a problem hiding this comment.
please take a look at dags/tpu_observability/tpu_sdk_monitoring_validation_dag.py, and apply the similar structure to this DAG
734c0f2 to
a4a2bb5
Compare
a4a2bb5 to
f915b51
Compare
… CLI validation specification
…handling and pattern matching
41f468f to
79f7f5c
Compare
1ba128e to
0fe6cba
Compare
b81c30b to
a12e062
Compare
721afcd to
8eb5556
Compare
acf36a1 to
a529792
Compare
83f8b37 to
ea29ef3
Compare
4af284a to
a9fa8fb
Compare
04a0b55 to
cd8b06c
Compare
Description
This PR introduces a new Airflow DAG, tpu_info_cli_validation_dags, designed to perform validation of the tpu-info CLI tool. The DAG ensures that the tool is correctly installed and functional across TPU worker pods.
Multi-Metric Validation:
Help (-help): Verifies that the help output contains all required CLI flags (e.g., --streaming, --rate, --list_metrics).
Version (--version): Ensures the tool correctly reports tpu-info version, libtpu version, and accelerator type.
Process (--process): Confirms the tool can successfully map active PIDs to TPU chips, identifying /dev/vfio/ paths and python processes.
Tests
cloud-ml-auto-solutions)2.13.1Checklist
Before submitting this PR, please make sure (put X in square brackets):