Skip to content

Add TPU Observability validation for help, version, and process monitoring - #165

Open
chengpinglin wants to merge 21 commits into
devfrom
tpu-obs/user/tony/dag_info_cli_02
Open

Add TPU Observability validation for help, version, and process monitoring#165
chengpinglin wants to merge 21 commits into
devfrom
tpu-obs/user/tony/dag_info_cli_02

Conversation

@chengpinglin

@chengpinglin chengpinglin commented Jan 7, 2026

Copy link
Copy Markdown

Description

This PR introduces a new Airflow DAG, tpu_info_cli_validation_dags, designed to perform validation of the tpu-info CLI tool. The DAG ensures that the tool is correctly installed and functional across TPU worker pods.

Multi-Metric Validation:

  • Help (-help): Verifies that the help output contains all required CLI flags (e.g., --streaming, --rate, --list_metrics).

  • Version (--version): Ensures the tool correctly reports tpu-info version, libtpu version, and accelerator type.

  • Process (--process): Confirms the tool can successfully map active PIDs to TPU chips, identifying /dev/vfio/ paths and python processes.

Tests

  • GCP Composer name: tony-test (under GCP project: cloud-ml-auto-solutions)
  • GCP Composer version: 2.13.1

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@ryanliuCienet ryanliuCienet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider combining the three _get_tpu_XXX functions into one, as they are nearly identical.

Regarding task_id, try to maintain consistency. In other words, either provide a task_id for all tasks, or only for those that might be easily confused (e.g., if multiple tasks share the same function, or the function name isn't descriptive enough).

@chengpinglin chengpinglin added WIP and removed WIP labels Jan 8, 2026
@chengpinglin

Copy link
Copy Markdown
Author

done.

Comment thread dags/tpu_observability/tpu_info_cli_validation_dags.py Outdated
@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from 5e1a734 to 34c3ce0 Compare January 9, 2026 07:28
@ryanliuCienet

Copy link
Copy Markdown

Overall LGTM, wait for @alfredyu-cienet to do the final review.

@chengpinglin
chengpinglin changed the base branch from tpu-obs/dev to dev January 13, 2026 06:23
@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from 0e56073 to 4ccf631 Compare January 13, 2026 06:25
@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from 4ccf631 to f3c43bc Compare January 14, 2026 02:46

@alfredyu-cienet alfredyu-cienet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's migrate to dags/tpu_observability/tpu_info_format_validation_dags.py

--> add the second with models.DAG(...) block in the same file

Comment thread dags/tpu_observability/tpu_info_format_validation_dags.py Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I supposed this file is no longer needed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from a65daa4 to eb88c98 Compare January 16, 2026 02:25
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 2 times, most recently from 1c93601 to 1ef36b1 Compare January 22, 2026 03:24
@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from eb88c98 to 8719639 Compare January 23, 2026 03:11

@alfredyu-cienet alfredyu-cienet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at dags/tpu_observability/tpu_sdk_monitoring_validation_dag.py, and apply the similar structure to this DAG

@chengpinglin
chengpinglin force-pushed the tpu-obs/user/tony/dag_info_cli_02 branch from 41f468f to 79f7f5c Compare March 20, 2026 01:56
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 4 times, most recently from 1ba128e to 0fe6cba Compare April 22, 2026 08:44
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 4 times, most recently from b81c30b to a12e062 Compare May 5, 2026 01:16
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 3 times, most recently from 721afcd to 8eb5556 Compare May 14, 2026 07:49
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 2 times, most recently from acf36a1 to a529792 Compare May 22, 2026 07:15
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 2 times, most recently from 83f8b37 to ea29ef3 Compare May 28, 2026 07:44
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 4 times, most recently from 4af284a to a9fa8fb Compare June 8, 2026 08:58
@alfredyu-cienet
alfredyu-cienet force-pushed the dev branch 2 times, most recently from 04a0b55 to cd8b06c Compare June 11, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants