Suggested fix for ImpfSetTropCyclone.get_countries_per_region() #1105#1106
Merged
Conversation
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
peanutfun
requested changes
Nov 21, 2025
peanutfun
left a comment
peanutfun
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! Please add a test for region="all".
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
peanutfun
requested changes
Feb 2, 2026
peanutfun
left a comment
peanutfun
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the test, but it basically doubles the contents of the CountryCode enum, which I think is error-prone. I like the idea of comparing two results of the get_countries_per_region(), though. How about you compare the partial contents of out to get_countries_per_region(reg) for each reg?
out_all = get_countries_per_region("all")
for reg in (...):
out_reg = get_countries_per_region(reg)
self.assertDictEqual(out[0][reg], out_all[0])
# ...and so on…et_countries_per_region
Collaborator
Author
|
@peanutfun Does this corresponds to what you had in mind? def test_get_countries_per_region_all_or_none(self):
ifs = ImpfSetTropCyclone()
out = ifs.get_countries_per_region()
out2 = ifs.get_countries_per_region("all")
self.assertEqual(out, out2)
for reg in CountryCode.REGION_NAME.value:
out_reg = ifs.get_countries_per_region(reg)
for i in range(4):
self.assertEqual(out[i][reg], out_reg[i])I've also added overloads. |
…et_countries_per_region
Collaborator
Author
|
Ready to merge? |
peanutfun
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #1105
PR Author Checklist
develop)PR Reviewer Checklist