Conversation
- Adds IB Optimization with docstrings and tests - Adds WIP convexity code, which will have tests and docstrings added soon
- Make the suboptimizer normalize properly so it does not throw errors occasionally
- Fixed suboptimizer to normalize so that errors do not occur with rounding - Made convexity project down points which do not span the space - Also vectorized convexity calculations for both one and higher dimensions - Added docstrings to all relevant functions - Separated optimization tests to another file - Suboptimization may be added but it is very difficult to figure out how to test it, since it is random - Added tests for convexity
Ashvin-Ranjan
changed the title
- Add test to cover edge case
shanest
requested changes
Jul 10, 2025
Contributor
shanest
left a comment
shanest
left a comment
There was a problem hiding this comment.
Great stuff! Mostly minor organizational stuff :)
| import random | ||
| import numpy as np | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Not sure (a) why this is its own file and (b) if so, why it's called suboptimizer. Move to utils?
Collaborator
Author
There was a problem hiding this comment.
The original plan was to have this file also include rotation/other ways to generate non-optimal encoders but I think that since that there is only this function I can move it to utils
Collaborator
Author
There was a problem hiding this comment.
Actually after trying this it creates a really annoying circular import sequence (since utils now has to use something from language and language uses utils) which ends up causing errors, so I think that it might be better to keep it as is for now.
- Fixed typos and added relevant docstrings - Created new utility function for repeated code - Added new paramaters to language_convexity - Added relevant test cases - Moved IB-related code into its own folder
shanest
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.