BB2-4927 Remove New Relic#1641
Draft
annamontare-nava wants to merge 74 commits into
Draft
Conversation
…d root_module We don't want all services to depend on the Datadog provider. root_module helps with tagging
Dashboards will only be provisioned once, whereas monitors will be provisioned per environment. Also, monitors are more critical than dashboards.
This allows the monitors to pull data with the correct tag.
Other APIs will likely have longer timeframes, so the defaults may change.
This prevents having to make changes in multiple places when updating root.tofu.tf, and I think is cleaner even though providers are now in two separate files.
This prevents having to make changes in multiple places when updating root.tofu.tf, and I think is cleaner even though providers are now in two separate files.
To be consistent with other services.
Because the defaults may change in the future
Will this work? Who knows.
This matches what CDAP has in their repo, and will pick up keys that are
in an `${env}.yml` but not in `defaults.yml`
So that it is not set as a plaintext environment variable
This reverts commit 525b597.
This will enable better tagging in Datadog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4927
What Does This PR Do?
Removes the New Relic agent and associated configuration from code and infrastructure.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)