chore: clean up and document TODOs in processing module#3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore: clean up and document TODOs in processing module#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Remove obsolete TODO at clause.cpp:2168 (duplicate source row check already implemented at lines 2296-2311 via matched_target_rows BitSet) - Clarify merge update insert TODOs with specific context about what insertion means and how empty vectors signal unmatched source rows - Document sparse target column limitation in merge_update_string_column_timeseries - Improve MergeClause parallel processing TODO with reference to ResampleClause - Strip internal Monday.com ticket references from all TODO comments - Fix misleading 'update must be done' wording to correctly say 'insert' - Add context to dynamic schema, Arrow support, and performance TODOs Files changed: clause.cpp (14 TODOs: 1 removed, 13 clarified) clause.hpp (2 TODOs clarified) clause_utils.cpp (1 TODO clarified) unsorted_aggregation.cpp (1 TODO clarified) Co-Authored-By: Chris Chappell <chris.chappell@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
N/A — GitHub issues are disabled on this repo. See TODO inventory below.
What does this implement or fix?
Audits and cleans up all 18 TODOs across
clause.cpp(14),clause.hpp(2),clause_utils.cpp(1), andunsorted_aggregation.cpp(1) in the processing module.Changes made:
Removed 1 obsolete TODO (
clause.cpp:2168): The comment requested exception handling for duplicate source-to-target row matches. This is already implemented at lines 2296-2311 via amatched_target_rowsBitSet that raisesE_INVALID_USER_ARGUMENT. Replaced with a brief note pointing to the existing validation.Clarified 17 remaining TODOs with improved context:
No functional code changes. All edits are comment-only.
TODO Inventory (for future tracking)
clause.cpp:140,151,2125,2386,2399clause.cpp:144for_each_enumeratedskips sparse positions, so matched source rows targeting sparse target positions won't be updated.clause.cpp:1563clause.cpp:2105process().clause.cpp:2183,2533,2544clause.cpp:2298,2453clause.hpp:118,124clause_utils.cpp:321unsorted_aggregation.cpp:492Any other comments?
These are purely comment/documentation changes — no logic was modified.
Checklist
Checklist for code changes...
Link to Devin session: https://app.devin.ai/sessions/7b17aae56da9472ba724c9658ee07783
Requested by: @chrischappell-cog