Resolve TODOs across 13 Python test files#6
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Conversation
- test_aggregation.py: Add 'first' and 'last' aggregators to parametrize (now un-feature flagged) - test_string.py: Remove Python 2 dead code branch and unused platform import - test_empty_column_type.py: Extract head/tail processing pipeline tests into separate TestAppendNonesHeadTailPipeline class - storage_test.py: Replace local create_df with import from arcticdb.util.test; remove resolved storage TODO - test_persistent_storage.py: Add skipif check for PERSISTENT_STORAGE_TESTS_ENABLED - test_engine.py: Add row_range read verification to test_partial_write_non_contiguous - conftest.py: Extend old_venv version params with 5.4.1, 5.9.3, 6.1.1 - test_snapshot.py: Remove lazy-fixture TODO (request.getfixturevalue is the standard pattern) - test_ternary.py: Add float64 dtype assertion for projected column (modify_schema now merged) - test_arrow_sparse.py: Add string/datetime column tests and offset resampling param - test_nonreg_specific.py: Clean up update logic, remove stale TODO - test_append.py: Remove stale commented-out AN-722 test case - test_s3.py (storage_fixtures): Fix rate limit cleanup with try/finally for test isolation Co-Authored-By: Chris Chappell <chris.chappell@cognition.ai>
Co-Authored-By: Chris Chappell <chris.chappell@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Resolves multiple long-standing TODOs across the test suite. References issues man-group#1394, man-group#1537, man-group#1951.
What does this implement or fix?
Resolves 18 TODOs across 13 Python test files:
test_aggregation.pyfirstandlastaggregators to parametrize (now un-feature flagged)test_string.pyplatformimporttest_empty_column_type.pyTestAppendNonesHeadTailPipelineclass (5 TODOs)storage_test.pycreate_dfwith import fromarcticdb.util.test; remove resolved storage TODOtest_persistent_storage.py@pytest.mark.skipifforPERSISTENT_STORAGE_TESTS_ENABLEDtest_engine.pytest_partial_write_non_contiguousconftest.pyold_venvversion params with 5.4.1, 5.9.3, 6.1.1test_snapshot.pyrequest.getfixturevalueis the standard pattern)test_ternary.pymodify_schemanow merged)test_arrow_sparse.pytest_nonreg_specific.pydataframe_arctic_updateTODO (man-group#1951 never merged)test_append.pytest_s3.py(storage_fixtures)TODOs intentionally left in place (still valid / cannot resolve in Python tests):
mark.py: MACOS_CONDA_BUILD flag still in active use; SSL issue Study and add tests for SSL verification for S3 on Windows and MacOS man-group/ArcticDB#1394 still openstorage_test.py(lines 102, 121): Functions await inclusion in released packagetest_arrow_read.py(5): Arrow write support still opt-intest_compact_data.py(3): macOS timestamp resolution workaroundtest_fork.py(2): Fork/multiprocessing infrastructure improvementstest_s3.py(integration): AWS InitAPI limitationtest_basic_version_store.py,test_library_tool.py,test_large_df.py,test_normalization.py,test_column_stats_creation.py,date.py: C++ layer / infrastructure issuesAny other comments?
No API changes. All changes are test-only.
Checklist
Checklist for code changes...
Link to Devin session: https://app.devin.ai/sessions/2e16302813274601af9de196433618f2
Requested by: @chrischappell-cog