Skip to content

Resolve TODOs across Python bindings, storage, and util C++ modules#7

Open
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1777289132-resolve-todos-python-storage-util
Open

Resolve TODOs across Python bindings, storage, and util C++ modules#7
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1777289132-resolve-todos-python-storage-util

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Apr 27, 2026

Copy link
Copy Markdown

Reference Issues/PRs

Jira issues created: CHRIS-70 through CHRIS-84

What does this implement or fix?

Resolves 39 TODO comments across 25 C++ files in the Python bindings, storage, and util modules.

Strategy:

  • 1 TODO resolved directly: sparse_utils.hpp — added bounds-checking assertion in densify_buffer_using_bitmap (the TODO simply said "add asserts")
  • 38 TODOs converted to Jira issue references: Each // TODO comment was replaced with a // CHRIS-XX: reference to a tracked Jira issue

Rapidcheck investigation: The pragma suppression for -Wdeprecated-declarations in rapidcheck.hpp remains necessary. The rapidcheck submodule is pinned at commit ff6af6f and the non-deprecated state API still segfaults at this version. The upstream rapidcheck project has not had significant updates to fix this.

Issue grouping (15 Jira issues):

Issue Area Description
CHRIS-70 Python bindings Refactor last_logical_row to infer from sparse_map (3 TODOs)
CHRIS-71 Python bindings Handle sparse data in PyRowRef/TickReader (2 TODOs)
CHRIS-72 Python bindings UTF strings, string arrays, string indexes, pandas absence (4 TODOs)
CHRIS-73 Python bindings Pandas >= 2.0 datetime64 resolution (1 TODO)
CHRIS-74 Python bindings Evaluate/remove TickReader class (1 TODO)
CHRIS-75 Storage Cache MongoDB database handles (3 TODOs)
CHRIS-76 Storage Remove WRITE_LOCK when refactoring StorageFailureSimulator (2 TODOs)
CHRIS-77 Storage Azure context static optimization + SDK error code workaround (2 TODOs)
CHRIS-78 Storage Config/size calculation improvements (5 TODOs)
CHRIS-79 Storage S3 buffer pool usage (1 TODO)
CHRIS-80 Util Migrate legacy error codes to specific ErrorCode enums (3 TODOs)
CHRIS-81 Util StringWrappingValue improvements (2 TODOs)
CHRIS-82 Util Test infrastructure: Windows logger, TMPDIR paths (3 TODOs)
CHRIS-83 Util Performance: BitSet enumerator, Decimal 128-bit, bitmap serializer (3 TODOs)
CHRIS-84 Util Rapidcheck improvements + input frame vector move (3 TODOs)

Any other comments?

  • All changes are comment-only except for sparse_utils.hpp which adds a util::check() bounds assertion and an ARCTICDB_DEBUG log line
  • Storage TODOs were handled conservatively — no behavioral changes, only comment updates to Jira references
  • clang-format (v19) was run on all changed files

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

Link to Devin session: https://app.devin.ai/sessions/3f459571f90a4b8f9f4ca66b7d63fb10
Requested by: @chrischappell-cog


Open in Devin Review

- Convert 38 TODO comments to Jira issue references (CHRIS-70 through CHRIS-84)
- Resolve sparse_utils.hpp TODO: add bounds-checking assertion in densify_buffer_using_bitmap
- Investigate rapidcheck pragma: non-deprecated API still segfaults at pinned commit ff6af6f
- Run clang-format on all changed files

TODOs grouped into 15 Jira issues:
  CHRIS-70: sparse_map refactor in python_handlers.cpp
  CHRIS-71: sparse data in PyRowRef/TickReader
  CHRIS-72: UTF strings, string arrays, string indexes, pandas absence
  CHRIS-73: Pandas >= 2.0 datetime64 resolution
  CHRIS-74: TickReader class evaluation
  CHRIS-75: MongoDB database handle caching
  CHRIS-76: StorageFailureSimulator WRITE_LOCK removal
  CHRIS-77: Azure context static optimization and SDK error code workaround
  CHRIS-78: Storage config/size calculation improvements
  CHRIS-79: S3 buffer pool usage
  CHRIS-80: Legacy error code migration
  CHRIS-81: StringWrappingValue improvements
  CHRIS-82: Test infrastructure (Windows logger, TMPDIR)
  CHRIS-83: Performance (BitSet enumerator, Decimal 128-bit, bitmap serializer)
  CHRIS-84: Rapidcheck improvements and input frame vector move

Co-Authored-By: Chris Chappell <chris.chappell@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant