Resolve TODOs across Python bindings, storage, and util C++ modules#7
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Convert 38 TODO comments to Jira issue references (CHRIS-70 through CHRIS-84) - Resolve sparse_utils.hpp TODO: add bounds-checking assertion in densify_buffer_using_bitmap - Investigate rapidcheck pragma: non-deprecated API still segfaults at pinned commit ff6af6f - Run clang-format on all changed files TODOs grouped into 15 Jira issues: CHRIS-70: sparse_map refactor in python_handlers.cpp CHRIS-71: sparse data in PyRowRef/TickReader CHRIS-72: UTF strings, string arrays, string indexes, pandas absence CHRIS-73: Pandas >= 2.0 datetime64 resolution CHRIS-74: TickReader class evaluation CHRIS-75: MongoDB database handle caching CHRIS-76: StorageFailureSimulator WRITE_LOCK removal CHRIS-77: Azure context static optimization and SDK error code workaround CHRIS-78: Storage config/size calculation improvements CHRIS-79: S3 buffer pool usage CHRIS-80: Legacy error code migration CHRIS-81: StringWrappingValue improvements CHRIS-82: Test infrastructure (Windows logger, TMPDIR) CHRIS-83: Performance (BitSet enumerator, Decimal 128-bit, bitmap serializer) CHRIS-84: Rapidcheck improvements and input frame vector move Co-Authored-By: Chris Chappell <chris.chappell@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Jira issues created: CHRIS-70 through CHRIS-84
What does this implement or fix?
Resolves 39 TODO comments across 25 C++ files in the Python bindings, storage, and util modules.
Strategy:
sparse_utils.hpp— added bounds-checking assertion indensify_buffer_using_bitmap(the TODO simply said "add asserts")// TODOcomment was replaced with a// CHRIS-XX:reference to a tracked Jira issueRapidcheck investigation: The pragma suppression for
-Wdeprecated-declarationsinrapidcheck.hppremains necessary. The rapidcheck submodule is pinned at commitff6af6fand the non-deprecated state API still segfaults at this version. The upstream rapidcheck project has not had significant updates to fix this.Issue grouping (15 Jira issues):
last_logical_rowto infer fromsparse_map(3 TODOs)PyRowRef/TickReader(2 TODOs)TickReaderclass (1 TODO)WRITE_LOCKwhen refactoringStorageFailureSimulator(2 TODOs)ErrorCodeenums (3 TODOs)StringWrappingValueimprovements (2 TODOs)Any other comments?
sparse_utils.hppwhich adds autil::check()bounds assertion and anARCTICDB_DEBUGlog lineclang-format(v19) was run on all changed filesChecklist
Checklist for code changes...
Link to Devin session: https://app.devin.ai/sessions/3f459571f90a4b8f9f4ca66b7d63fb10
Requested by: @chrischappell-cog