feat: Migrate from Java 9 to Java 11#2
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
Bot
force-pushed
the
devin/java8-to-11
branch
from
f0caaee to
3a767e0
Compare
devin-ai-integration
Bot
changed the title
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
- Upgrade maven-compiler-plugin 3.1 → 3.11.0, use <release>11</release> - Upgrade JUnit 4.11 → 4.13.2 (scoped to test) - Upgrade JMH 1.17.4 → 1.37 - Add maven-surefire-plugin 3.2.5, maven-failsafe-plugin 3.2.5 - Add maven-enforcer-plugin 3.5.0 requiring Java [11,) - Move ReadPositiveIntParam.java from src/main to src/test - Add .gitignore exception for .github directory - Add 6 integration test files covering chapters 1, 4, 5, 10, 11, 12 - Add GitHub Actions CI workflow (.github/workflows/ci.yml) - Add MIGRATION_NOTES.md documenting all changes - Update README.md with JDK 11 requirement Co-Authored-By: Lukas Burger <lukaskburger@gmail.com>
devin-ai-integration
Bot
force-pushed
the
devin/java8-to-11
branch
from
3a767e0 to
37f0082
Compare
devin-ai-integration
Bot
changed the title
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.2.5</version> | ||
| </plugin> |
There was a problem hiding this comment.
🟡 Surefire skips the moved JUnit class because its name does not match test includes
The PR moves ReadPositiveIntParam under src/test/java, but the class still keeps the name ReadPositiveIntParam and its JUnit method is at src/test/java/lambdasinaction/chap10/ReadPositiveIntParam.java:10-13. Surefire’s default includes only run classes matching patterns such as Test*, *Test, *Tests, or *TestCase; the newly added Surefire configuration does not add an include for this class, so mvn test/CI will silently skip the migrated test even though the migration notes say it was moved because it contains JUnit tests.
Prompt for agents
The migrated JUnit class src/test/java/lambdasinaction/chap10/ReadPositiveIntParam.java is not discovered by Maven Surefire because its class name does not match the default test include patterns. Either rename the class and file to a Surefire-discoverable name such as ReadPositiveIntParamTest, or configure the maven-surefire-plugin in pom.xml to include this specific test class. Ensure mvn test actually executes its testMap method.
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <version>3.2.5</version> | ||
| </plugin> |
There was a problem hiding this comment.
🚩 Added failsafe plugin does not run integration tests by itself
The new Failsafe plugin is declared but has no executions bound to integration-test/verify, and the CI workflow only runs mvn -B test. That is not a bug for the current PR because all added tests are regular Surefire-style JUnit classes under src/test/java and their names end in Test; however, the migration notes' phrase "integration test support" may be misleading unless future work binds Failsafe goals or CI runs mvn verify.
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
…t none) [feature] Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
1 participant
Summary
Migrates
manning:lambdasinactionfrom Java 9 (source/target 1.9) to Java 11 (LTS) with minimal, behavior-preserving changes: modern Maven build tooling targetingrelease 11, upgraded test/bench deps, a Temurin JDK 11 CI workflow, and docs. No removed JDK modules (JAXB/JAX-WS/JavaFX/CORBA) are used, so no replacement dependencies were needed.Build
maven.compiler.release=11(replaces<source>/<target>).maven-compiler-plugin3.1 → 3.11.0 with<release>11</release>.maven-surefire-plugin3.2.5,maven-failsafe-plugin3.2.5.maven-enforcer-plugin3.5.0 withrequireJavaVersion [11,).maven-javadoc-plugin3.6.3 with<doclint>none</doclint>.maven-shade-pluginpinned to 3.6.2 (was unversioned → Maven "build stability" warning).<scope>test</scope>), JMH 1.17.4 → 1.37.Removals / Replacements
javax.activation/ JavaFX / CORBA (org.omg.*) / Nashorn /sun.*usage found.Encapsulation
module-info.java). No illegal reflective access warnings; no--add-opensneeded.Security / GC
Validation
mvn clean verifyon Temurin JDK 11: BUILD SUCCESS, 51 tests pass (chap1/4/5/10/11/12), enforcerRequireJavaVersion [11,)passes, compiled class major version 55..github/workflows/ci.yml(Temurin JDK 11 + Maven cache) — green on this branch.chap10/ReadPositiveIntParam@Testlived undersrc/main/javaand was never run by Surefire — moved tosrc/test/java).Follow-ups
var,Files.readString/writeString,java.net.http.HttpClient).See MIGRATION_NOTES.md.
Link to Devin session: https://app.devin.ai/sessions/0f681c2f12a941049063f1160fe22e36
Requested by: @TheWuster935
Devin Review
e4ff4a5