Upgrade from Java 8 to Java 11#3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Update maven-compiler-plugin source/target/release from 1.9 to 11 - Bump maven-compiler-plugin version from 3.1 to 3.8.1 - Add maven.compiler.source and maven.compiler.target properties - Update README.md to reference JDK 11+ and Adoptium Co-Authored-By: derek.wu <derekwu35@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 8/9 to Java 11.
Changes:
maven-compiler-pluginfrom 3.1 to 3.8.1, changedsource/targetfrom1.9to11, addedreleaseflag for Java 11, and addedmaven.compiler.source/maven.compiler.targetpropertiesjava -versionoutputAll 100 source files compile cleanly with Java 11. No removed/deprecated API usage was found (no
javax.xml.bind,sun.misc, etc.).Review & Testing Checklist for Human
mvn clean compilewith JDK 11 to verify compilationcd target/classes && java lambdasinaction/chap1/FilteringApplesNotes
The pom.xml previously had
source/targetset to1.9(Java 9), not1.8as the README suggested. This PR normalizes everything to Java 11.Link to Devin session: https://app.devin.ai/sessions/4758be018bb5443b934397e37fee2219
Requested by: @TheWuster935
Devin Review