feature: upgrade build from Java 9 to Java 17 (LTS)#5
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feature: upgrade build from Java 9 to Java 17 (LTS)#5devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades this educational Maven project's toolchain from Java 9 to Java 17 (LTS). The build was previously pinned to
1.9and used plugin/dependency versions that predate JDK 17 support.mvn clean verifynow passes on JDK 17 with no source-code changes required — all the Streams/Lambda/CompletableFuture examples compile unmodified.pom.xmlchangesmaven-compiler-plugin<source>1.9</source>/<target>1.9</target>with a single<release>17</release>(also surfaced as themaven.compiler.releaseproperty).maven-compiler-plugin3.1 → 3.11.0: 3.1 cannot emit class file version 61 / doesn't understand<release>.maven-shade-plugin: pinned to 3.4.1 (was unversioned, which resolved to an ancient default that fails on JDK 17's ASM/bytecode level). The benchmark uber-jar (benchmarks.jar) still builds.jmh.versionproperty): older JMH bundles an ASM that rejects Java 17 bytecode during annotation processing.dependency-reduced-pom.xml(generated by the shade plugin) to.gitignore.Code changes
None. No examples used APIs removed/changed after Java 9, so no migration edits were needed.
Validation
mvn clean verifyonjava -version= 17.0.19 → BUILD SUCCESS. The repo has nosrc/testtest classes, so there were no existing tests to run; surefire reported no tests and the build (incl. shade packaging) completes cleanly.Residual risks
Link to Devin session: https://app.devin.ai/sessions/267a079877f94aa19879f0ceb6c2f2c8
Requested by: @vibhaseshadri-cognition
Devin Review