Skip to content

Upgrade build to Java 17 (LTS)#6

Open
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
upgrade/java17
Open

Upgrade build to Java 17 (LTS)#6
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
upgrade/java17

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 29, 2026

Copy link
Copy Markdown

Summary

Upgrades the Maven build from Java 9 to Java 17 (LTS). The source is already Java 17-compatible (no javax/sun imports; uses Optional.or()), so the change is confined to pom.xml: modernizing the compiler config and bumping plugin/dependency versions so the reactor builds cleanly on JDK 17.

Changes in pom.xml:

  • maven-compiler-plugin 3.13.13.0, replacing <source>1.9</source>/<target>1.9</target> with <release>17</release>.
  • JMH (jmh-core, jmh-generator-annprocess) 1.17.41.37 (older JMH's annotation processor fails on modern JDKs).
  • maven-shade-plugin version pinned to 3.6.0 (was previously unpinned).
- maven-compiler-plugin 3.1   <source>1.9</source> <target>1.9</target>
+ maven-compiler-plugin 3.13.0 <release>17</release>
- jmh-core / jmh-generator-annprocess 1.17.4
+ jmh-core / jmh-generator-annprocess 1.37
- maven-shade-plugin (unpinned)
+ maven-shade-plugin 3.6.0

Validation

  • mvn clean verify succeeds on Java 17 (openjdk 17.0.19), including JMH annotation processing and the shaded benchmarks.jar build.
  • java -jar target/benchmarks.jar -l lists the benchmarks (e.g. lambdasinaction.chap7.ParallelStreamBenchmark.*), confirming the uber-jar's JMH manifest is intact.
  • No JUnit tests exist under src/test, so surefire runs none. Per task scope, no CI workflows were added.

Link to Devin session: https://app.devin.ai/sessions/7161a2eb553044088f2aea1ca8953206
Requested by: @vibhaseshadri-cognition


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

…n shade-plugin 3.6.0

Co-Authored-By: Vibha  Seshadri <vibha.seshadri@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants