ci: Migrate Jenkins pipelines to GitHub Actions#197
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
ci: Migrate Jenkins pipelines to GitHub Actions#197devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Add .github/workflows/ci.yml (build, Trivy scan, OWASP check, SonarQube, Docker build/push) - Add .github/workflows/cd.yml (update K8s manifest, commit & push) - Remove Jenkinsfile, GitOps/Jenkinsfile, and vars/ shared library - Update README.md tech stack to reflect GitHub Actions Co-Authored-By: vanessa.salas <vanessa.salas@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Skip Docker buildx/push steps when DOCKERHUB_USERNAME secret is not set - Fall back to plain docker build (no push) when secrets are missing - Fix SonarQube conditionals to use secrets context directly Co-Authored-By: vanessa.salas <vanessa.salas@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Jenkins CI and CD pipelines (and the Groovy shared library) with equivalent GitHub Actions workflows.
CI workflow (
.github/workflows/ci.yml) — runs on push/PR toDevOps/main:SONAR_TOKENsecret)DOCKERHUB_USERNAMEsecret; falls back to local-only build)repository_dispatchCD workflow (
.github/workflows/cd.yml) — triggered by CI or manual dispatch:kubernetes/bankapp-deployment.ymlviasedRemoved:
Jenkinsfile(CI pipeline)GitOps/Jenkinsfile(CD pipeline)vars/directory (17 Groovy shared library files)Other:
README.mdtech stack updated from "Jenkins (CI)" to "GitHub Actions (CI/CD)"Review & Testing Checklist for Human
DOCKERHUB_USERNAME,DOCKERHUB_TOKEN, and optionallySONAR_TOKEN,SONAR_HOST_URL,GH_PAT. Without DockerHub secrets, CI will only build the image locally (no push). Without SonarQube secrets, those steps are skipped entirely.${{ secrets.GH_PAT || github.token }}— verify this expression correctly falls back togithub.tokenwhenGH_PATis not set. The CD job needs write/push permissions on the repo; the defaultgithub.tokenmay not have sufficient permissions depending on repo settings.emailext. The GHA replacement writes a job summary but does not send email. Confirm this is acceptable or add an email notification step (e.g., viadawidd6/action-send-mail).workflow_dispatch) with a test docker tag and verify each step passes. Then trigger the CD workflow and confirm the K8s manifest is updated correctly.Notes
docker buildruns instead so the build is still validated.continue-on-error: trueto avoid blocking the pipeline on non-critical failures, matching the original Jenkins behavior.sedregex in the CD workflow (image: .*/bankapp.*) is broader than the original Jenkins regex (trainwithshubham/bankapp-eks:.*). This should be fine for the current manifest but could over-match if additional bankapp-related image references are added.Link to Devin session: https://app.devin.ai/sessions/47131ba3402a43a1b475de79c44893c5
Requested by: @vanessasalas-cog
Devin Review