Skip to content

feature: upgrade to Java 21, Spring Boot 3.4.7, modern Docker base images #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: DevOps
Choose a base branch
from
Open

feature: upgrade to Java 21, Spring Boot 3.4.7, modern Docker base images #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3ab40f
feature: upgrade to Java 21, Spring Boot 3.4.7, modern Docker base im…
devin-ai-integration[bot] Jun 18, 2026
8c229ac
bug: replace deprecated Hibernate MySQL8Dialect with MySQLDialect
devin-ai-integration[bot] Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
#----------------------------------

# Import docker image with maven installed
FROM maven:3.8.3-openjdk-17 as builder
FROM maven:3.9-eclipse-temurin-21 AS builder

# Add maintainer, so that new user will understand who had written this Dockerfile
MAINTAINER Madhup Pandey<madhuppandey2908@gmail.com>
LABEL maintainer="Madhup Pandey<madhuppandey2908@gmail.com>"

# Add labels to the image to filter out if we have multiple application running
LABEL app=bankapp
Expand All @@ -25,7 +25,7 @@ RUN mvn clean install -DskipTests=true
#--------------------------------------

# Import small size java image
FROM openjdk:17-alpine as deployer
FROM eclipse-temurin:21-jre-alpine AS deployer

# Copy build from stage 1 (builder)
COPY --from=builder /src/target/*.jar /src/target/bankapp.jar
Expand Down
18 changes: 4 additions & 14 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.3.3</version>
<version>3.4.7</version>

@devin-ai-integration devin-ai-integration Bot Jun 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Deprecated Hibernate dialect in application.properties may emit warnings after upgrade

The application.properties:10 still references org.hibernate.dialect.MySQL8Dialect, which was deprecated in Hibernate 6.2+ (shipped with Spring Boot 3.2+). With the upgrade to Spring Boot 3.4.7 (Hibernate 6.6.x), this will still work but logs a deprecation warning at startup. The recommended approach is to either switch to org.hibernate.dialect.MySQLDialect or remove the property entirely and let Hibernate auto-detect the dialect. Not a bug since it still functions, but worth cleaning up as part of this upgrade.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jun 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — fixed in 8c229ac by switching application.properties to org.hibernate.dialect.MySQLDialect. Confirmed the HHH90000026 deprecation warning no longer appears on startup and mvn test still passes.

<relativePath/> <!-- lookup parent from repository -->
</parent>
<groupId>com.example</groupId>
Expand All @@ -27,7 +27,7 @@
<url/>
</scm>
<properties>
<java.version>17</java.version>
<java.version>21</java.version>
</properties>
<dependencies>
<dependency>
Expand All @@ -52,9 +52,8 @@
</dependency>

<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
<version>8.0.33</version>
<groupId>com.mysql</groupId>
<artifactId>mysql-connector-j</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
Expand All @@ -75,15 +74,6 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver

# JPA & Hibernate configuration
spring.jpa.hibernate.ddl-auto=update
spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.MySQL8Dialect
spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.MySQLDialect
spring.jpa.show-sql=true