build: migrate Java 17 to Java 21#256
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Co-Authored-By: aman.thind <aman.thind@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
Runtime test — Java 21 migration ✅Ran the app locally via E2E flow (register → login → deposit → transactions)
Build / runtime evidence
Devin session: https://app.devin.ai/sessions/91d43ce48dbb41598d9ed0d3727df844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the build and runtime from Java 17 to Java 21. Spring Boot
spring-boot-starter-parent3.3.3 already supports Java 21, so no Spring Boot bump is needed.pom.xml<java.version>17</java.version>→21.maven-compiler-pluginblock, which was incorrectly pinning<source>1.8</source>/<target>1.8</target>. The parent POM now manages the compiler plugin and drives--release 21from thejava.versionproperty.Dockerfilemaven:3.8.3-openjdk-17→maven:3.9-eclipse-temurin-21.openjdk:17-alpine→eclipse-temurin:21-jre-alpine(theopenjdkDocker Hub repo is deprecated with no 21 tag).Jenkinsfile and GitOps/Jenkinsfile build via Docker and don't pin a JDK tool, so they need no changes.
Verification
mvn clean installcompiles with--release 21; emitted bytecode is major version 65 (Java 21).docker build .succeeds with both new base images.Link to Devin session: https://app.devin.ai/sessions/91d43ce48dbb41598d9ed0d3727df844
Devin Review