feature: migrate to Java 21 (LTS) and modernize Docker base images#263
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feature: migrate to Java 21 (LTS) and modernize Docker base images#263devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- pom.xml: java.version 17 -> 21, remove maven-compiler-plugin override (was forcing source/target 1.8); switch mysql-connector-java 8.0.33 -> com.mysql:mysql-connector-j (version managed by Spring Boot parent) - Dockerfile: maven:3.8.3-openjdk-17 -> maven:3.9-eclipse-temurin-21 builder; openjdk:17-alpine -> eclipse-temurin:21-jre-alpine deployer Co-Authored-By: Amit Manchella <amit.manchella@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the BankApp from its inconsistent Java config to Java 21 (LTS). Previously
pom.xmlhad<java.version>17</java.version>but an explicitmaven-compiler-pluginoverrode it to compile for1.8. This resolves that conflict and lets thespring-boot-starter-parent(3.3.3) manage compilation.pom.xmlDockerfile(two-stage)CI/CD & Kubernetes — no changes required
Jenkinsfile,GitOps/Jenkinsfile, andvars/*.groovy(incl.deploy.groovy) build via Docker /docker composeand contain nojdktool declarations, Java-version agent images, or Maven steps pinned to Java 17 — the JDK is fully controlled by the Dockerfile.kubernetes/bankapp-deployment.ymluses the app image tagtrainwithshubham/bankapp-eks:v2(not a Java-versioned base image);mysql:8.0is unrelated. Nothing to update.Verification
mvn clean verifywith Java 21 (against a live MySQL 8): BUILD SUCCESS, compiles withrelease 21, tests pass (Tests run: 1, Failures: 0, Errors: 0). No deprecated-API orInaccessibleObjectExceptionregressions surfaced.Link to Devin session: https://app.devin.ai/sessions/c6aa88af32784ca094fc2d855cfa60ff
Requested by: @amitmanchella-cog
Devin Review