feature: upgrade to Java 25 & Spring Boot 3.5.x (pom.xml)#268
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feature: upgrade to Java 25 & Spring Boot 3.5.x (pom.xml)#268devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Maven build to Java 25 and Spring Boot 3.5.16 (latest stable 3.5.x on Maven Central, published 2026-06-25). Scoped to
pom.xmlonly — no changes to Dockerfile, docker-compose, README, helm, or kubernetes files.Chosen Spring Boot version: 3.5.16. The Spring Boot parent transitively manages Hibernate/Tomcat and the JDBC driver, so none of those are pinned manually.
Changes (
pom.xml)spring-boot-starter-parent3.3.3→3.5.16.<java.version>17</java.version>→<java.version>25</java.version>.maven-compiler-pluginblock entirely (it hardcoded<source>1.8</source>/<target>1.8</target>); compilation is now managed by the Spring Boot parent viajava.version=25.mysql:mysql-connector-java:8.0.33→com.mysql:mysql-connector-j(resolves to9.7.0via the BOM; kept<scope>runtime</scope>).Verification
Built and tested on Temurin JDK 25 (
25.0.3+9-LTS) against a real MySQL 8 on localhost:3306../mvnw clean test:(The repo's suite is a single
BankappApplicationTests.contextLoads()test — all green.)App boots on JDK 25:
./mvnw spring-boot:runserves http://localhost:8080 with the login page at/login.CI note —
license/snykchecksecurity/snykpasses.license/snykfails on 1 license issue: GPL-2.0 (copyleft) oncom.mysql:mysql-connector-j.This is not a new licensing risk. The base
DevOpsbranch already ships the MySQL connector under the same license (mysql-connector-java:8.0.33is also "GPL v2 with Universal FOSS Exception v1.0"). The old artifact declared its license only in a free-text POM comment that Snyk could not parse, whereas the newmysql-connector-jartifact declaresGPL-2.0in structured<licenses>metadata — so Snyk now detects the pre-existing copyleft license and the org policy flags it as "new".The GPL license is inherent to Oracle's MySQL JDBC driver regardless of coordinate. Clearing this check would require either reverting the (explicitly requested) connector coordinate change, switching to a different driver (e.g. MariaDB Connector/J, LGPL — a behavioral change out of scope for this pom-only PR), or adding a Snyk license-policy exception. Flagging for reviewer decision rather than working around the policy.
Link to Devin session: https://app.devin.ai/sessions/c1fa2223d05545429a087eb4748850bc
Requested by: @Colhodm
Devin Review