Skip to content

feat: upgrade Angular 9 → 20 (Wave 1 — core framework + build config) #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobydrinkall wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: upgrade Angular 9 → 20 (Wave 1 — core framework + build config) #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c937658
feat: upgrade Angular 9 → 20 (core framework + build config)
devin-ai-integration[bot] Jul 2, 2026
694a9eb
refactor: migrate browser builder to application builder (esbuild)
devin-ai-integration[bot] Jul 2, 2026
ae50b40
fix: remove deleted polyfills.ts from tsconfig.spec.json, update fire…
devin-ai-integration[bot] Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions browserslist → .browserslistrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
# For additional information regarding the format and rule options, please see:
# https://github.com/browserslist/browserslist#queries

# You can see what browsers were selected by your queries by running:
# npx browserslist

> 0.5%
last 2 versions
last 2 Chrome versions
last 1 Firefox version
last 2 Edge major versions
last 2 Safari major versions
last 2 iOS major versions
Firefox ESR
not dead
not IE 9-11 # For IE 9-11 support, remove 'not'.
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ testem.log
# System Files
.DS_Store
Thumbs.db
.angular/
30 changes: 14 additions & 16 deletions angular.json
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"builder": "@angular-devkit/build-angular:application",
"options": {
"aot": true,
"outputPath": "dist/angular-hnpwa",
"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"browser": "src/main.ts",
Comment on lines +18 to +22

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Migration to application builder changes output directory structure

The builder was changed from @angular-devkit/build-angular:browser to @angular-devkit/build-angular:application (angular.json:18), and the entry point key changed from main to browser (line 22). The application builder (esbuild-based) produces a different output directory structure than the old browser builder (webpack-based): output goes into dist/angular-hnpwa/browser/ subdirectory rather than directly into dist/angular-hnpwa/. Any deployment scripts, CI pipelines (.travis.yml), or Firebase hosting config (firebase.json) that reference the old output path may need updating.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — updated firebase.json public path from "dist" to "dist/angular-hnpwa/browser" to match the application builder's output structure. Fixed in ae50b40.

"polyfills": [
"zone.js"
],
"tsConfig": "tsconfig.app.json",
"assets": [
"src/favicon.ico",
Expand All @@ -45,12 +46,8 @@
"optimization": true,
"outputHashing": "all",
"sourceMap": true,
"extractCss": true,
"namedChunks": true,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
Expand All @@ -62,33 +59,35 @@
"maximumWarning": "6kb"
}
],
"serviceWorker": true,
"ngswConfigPath": "ngsw-config.json"
"serviceWorker": "ngsw-config.json"
}
}
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "angular-hnpwa:build"
"buildTarget": "angular-hnpwa:build"
},
"configurations": {
"production": {
"browserTarget": "angular-hnpwa:build:production"
"buildTarget": "angular-hnpwa:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "angular-hnpwa:build"
"buildTarget": "angular-hnpwa:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "src/test.ts",
"polyfills": "src/polyfills.ts",
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"assets": [
Expand Down Expand Up @@ -129,6 +128,5 @@
}

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Angular lint/e2e architect targets reference removed/deprecated builders

The angular.json still contains lint and e2e architect targets using @angular-devkit/build-angular:tslint and @angular-devkit/build-angular:protractor respectively. Both builders were removed from @angular-devkit/build-angular after Angular 12. Running ng lint or ng e2e will fail with Angular 20's build tooling. These targets should either be removed or migrated to their modern equivalents (ESLint and Cypress/Playwright).

(Refers to lines 104-128)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional deferral — TSLint→ESLint and Protractor removal (including these angular.json targets) are scoped to Wave 4 (child session on branch upgrade/test-lint). See earlier reply.

}
}
},
"defaultProject": "angular-hnpwa"
}
}
2 changes: 1 addition & 1 deletion firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"rules": "database.rules.json"
},
"hosting": {
"public": "dist",
"public": "dist/angular-hnpwa/browser",
"rewrites": [
{
"source": "**",
Expand Down
Loading