chore: Wave 4 — Migrate TSLint → ESLint, update test tooling, remove Protractor#429
Open
tobydrinkall wants to merge 1 commit into
Open
chore: Wave 4 — Migrate TSLint → ESLint, update test tooling, remove Protractor#429tobydrinkall wants to merge 1 commit into
tobydrinkall wants to merge 1 commit into
Conversation
- Remove tslint, codelyzer, protractor from devDependencies - Delete tslint.json and e2e/ directory - Add ESLint 9 flat config with angular-eslint and typescript-eslint - Update angular.json lint builder to @angular-eslint/builder:lint - Update karma to ~6.4.0, jasmine-core to ~5.1.0, karma-jasmine to ~5.1.0 - Replace karma-coverage-istanbul-reporter with karma-coverage ~2.2.0 - Update @types/jasmine to ~5.1.0, @types/node to ^20.0.0, ts-node to ~10.9.0 - Update karma.conf.js to use karma-coverage - Fix test.ts to remove deprecated require.context pattern - Fix lint errors: unused imports, prefer-const, component selector prefix - Add smoke tests for AppComponent and CommentPipe Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Wave 4 of the Angular 9→20 upgrade: replaces the deprecated lint/test/e2e toolchain with modern equivalents.
TSLint → ESLint migration:
tslint,codelyzer,tslint.jsoneslint.config.js) withangular-eslint+typescript-eslintangular.jsonlint architect from@angular-devkit/build-angular:tslint→@angular-eslint/builder:lintprefer-standalone(existing module-based code), accessibility rules set towarnTest tooling update:
karma4.1→6.4,jasmine-core3.4→5.1,karma-jasmine2.0→5.1karma-coverage-istanbul-reporterwithkarma-coverage~2.2@types/jasmine3.3→5.1,@types/node^12→^20,ts-node7.0→10.9require.context()pattern fromsrc/test.tsProtractor removal:
e2e/directory, removesprotractordep, removes e2e architect target and scriptCode fixes to satisfy new lint rules:
Observableimport, prefixes unused catch params with_<item>selector →<app-item>(component-selector rule)let→constwhere applicableAdded spec files:
app.component.spec.ts— smoke tests for AppComponent creationcomment.pipe.spec.ts— unit tests for CommentPipe transform logicAll 6 tests pass, build succeeds, lint exits 0 (warnings only).
Link to Devin session: https://app.devin.ai/sessions/15a0c4a1bf2e4414b1dd6ebac6de959d
Requested by: @tobydrinkall
Devin Review