-
Notifications
You must be signed in to change notification settings - Fork 13
Upgrade Java target from 11 to 17 #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
b9489bc
1cff634
f0dbfde
7886b95
9e80159
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Java CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - '**' | ||
| tags: | ||
| - 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10 | ||
| pull_request: | ||
| branches: | ||
| - '**' | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: zulu | ||
| java-version: '17' | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.gradle/caches | ||
| ~/.gradle/wrapper | ||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-gradle- | ||
| - name: Test with Gradle | ||
| run: ./gradlew clean test |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # API Configuration | ||
| VITE_API_BASE_URL=http://localhost:8080 | ||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚩 Root .env inclusion is deliberate but production defaults should be reviewed The PR commits Was this helpful? React with 👍 or 👎 to provide feedback. Debug |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # API Configuration | ||
| # Copy this file to .env and update the values as needed | ||
| VITE_API_BASE_URL=http://localhost:8080 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| # RealWorld Frontend | ||
|
|
||
| A modern React frontend application that consumes the Spring Boot RealWorld API. | ||
|
|
||
| ## Features | ||
|
|
||
| - **User Authentication** - Registration, login, JWT token management | ||
| - **Article Management** - Create, view, edit, delete articles with markdown support | ||
| - **Article Feed** - Global feed displaying all articles with pagination | ||
| - **User Profiles** - User information and article listings | ||
| - **Comments System** - Add and view comments on articles | ||
| - **Social Features** - Following users, favoriting articles | ||
| - **Tag System** - Article categorization and filtering | ||
| - **Responsive Design** - Modern UI built with Tailwind CSS | ||
|
|
||
| ## Technology Stack | ||
|
|
||
| - **React 18** with TypeScript for type safety | ||
| - **Vite** for fast development and building | ||
| - **Tailwind CSS** for modern, responsive styling | ||
| - **React Router** for navigation | ||
| - **Axios** for API communication with JWT authentication | ||
|
|
||
| ## Getting Started | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| - Node.js 16+ and npm | ||
| - Spring Boot backend running on http://localhost:8080 | ||
|
|
||
| ### Installation | ||
|
|
||
| ```bash | ||
| cd frontend | ||
| npm install | ||
| ``` | ||
|
|
||
| ### Development | ||
|
|
||
| ```bash | ||
| npm run dev | ||
| ``` | ||
|
|
||
| The application will be available at http://localhost:3000 | ||
|
|
||
| ### Build for Production | ||
|
|
||
| ```bash | ||
| npm run build | ||
| ``` | ||
|
|
||
| ## API Integration | ||
|
|
||
| The frontend integrates with the Spring Boot RealWorld API running on localhost:8080: | ||
|
|
||
| - **Authentication**: POST /users/login, POST /users | ||
| - **Articles**: GET/POST/PUT/DELETE /articles | ||
| - **Profiles**: GET /profiles/{username} | ||
| - **Comments**: GET/POST/DELETE /articles/{slug}/comments | ||
| - **Tags**: GET /tags | ||
|
|
||
| All API calls include proper JWT authentication headers in the format: `Authorization: Token {jwt}` | ||
|
|
||
| ## Project Structure | ||
|
|
||
| ``` | ||
| frontend/ | ||
| ├── src/ | ||
| │ ├── components/ # Reusable UI components | ||
| │ ├── pages/ # Page components (Home, Login, Register, etc.) | ||
| │ ├── services/ # API integration layer | ||
| │ ├── hooks/ # Authentication context and hooks | ||
| │ ├── types/ # TypeScript interfaces | ||
| │ └── App.tsx # Main application component | ||
| ├── package.json # Dependencies and scripts | ||
| ├── vite.config.ts # Vite configuration | ||
| ├── tailwind.config.js # Tailwind CSS configuration | ||
| └── tsconfig.json # TypeScript configuration | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>RealWorld</title> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.tsx"></script> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Frontend build is not exercised by the existing CI workflow
The PR adds a separate
frontend/package.jsonwithbuild,lint, and Vite scripts, but the only workflow still runs./gradlew clean testfor the backend. This means frontend regressions will not be caught unless another pipeline outside this repo runsnpm ci/npm run build/npm run lint. This is not a runtime bug in the application code, but reviewers should decide whether the newly added frontend is intended to be part of this repository’s required CI surface.(Refers to lines 33-34)
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
Playground