Extra ABC Voting tests

Author: Simon-Rey

tests/test_rules/test_on_abcvoting_instances.py

@@ -16,6 +16,7 @@
     MaxSatisfactionILPBuilder,
 )
 from trivoting.rules.chamberlin_courant import chamberlin_courant
+from trivoting.rules.max_satisfaction import max_satisfaction_ilp, max_satisfaction
 from trivoting.rules.thiele import (
     thiele_method,
     PAVILPKraiczy2025,
@@ -114,6 +115,8 @@ def exhaustivee_cc(
         partial(sequential_thiele, thiele_score_class=ApprovalOnlyScore),
         partial(sequential_thiele, thiele_score_class=SatisfactionScore),
         partial(thiele_method, ilp_builder_class=MaxSatisfactionILPBuilder),
+        max_satisfaction_ilp,
+        max_satisfaction,
     ],
     "cc": exhaustivee_cc,
     # ABCvoting only has MES with completion...

trivoting/rules/max_satisfaction.py

@@ -157,6 +157,8 @@ def max_satisfaction(
     max_seconds: int = 600,
     verbose: bool = False,
 ) -> Selection | list[Selection]:
+    if not resoluteness:
+        raise NotImplementedError("Max Satisfaction does not yet support resoluteness=False.")
     alt_scores = profile.support_dict()
     if initial_selection is None:
         selection = Selection(implicit_reject=True)