Trying to understand what's up with the tests

Author: Simon-Rey

tests/test_papers/test_KPPS25.py

@@ -52,9 +52,9 @@ def test_mes_tax(self):
         selection = tax_method_of_equal_shares(profile, max_size)
         categorised_selection = [[], [], []]
         for alt in selection.selected:
-            if alt.name < 11:
+            if int(alt.name) < 11:
                 categorised_selection[0].append(alt)
-            elif alt.name < 21:
+            elif int(alt.name) < 21:
                 categorised_selection[1].append(alt)
             else:
                 categorised_selection[2].append(alt)
@@ -69,9 +69,9 @@ def test_phragmen_tax(self):
         selection = tax_sequential_phragmen(profile, max_size)
         categorised_selection = [[], [], []]
         for alt in selection.selected:
-            if alt.name < 11:
+            if int(alt.name) < 11:
                 categorised_selection[0].append(alt)
-            elif alt.name < 21:
+            elif int(alt.name) < 21:
                 categorised_selection[1].append(alt)
             else:
                 categorised_selection[2].append(alt)
@@ -86,16 +86,16 @@ def test_epjr(self):
         def generate_positive_selection():
             res = Selection(implicit_reject=True)
             for a in random.sample(range(1, 21), 3):
-                res.selected.append(profile.get_alternative_by_name(a))
+                res.add_selected(profile.get_alternative_by_name(str(a)))
             for a in random.sample(range(21, 31), 3):
-                res.selected.append(profile.get_alternative_by_name(a))
+                res.add_selected(profile.get_alternative_by_name(str(a)))
 
             alts = [a for a in profile.alternatives if not res.is_selected(a)]
             random.shuffle(alts)
             num_selected = 6
             for alt in alts:
                 if random.random() < 4 / len(profile.alternatives):
-                    res.selected.append(alt)
+                    res.add_selected(alt)
                     num_selected += 1
                 if num_selected == max_size:
                     break
@@ -112,9 +112,9 @@ def generate_negative_selection():
             res = Selection(implicit_reject=True)
 
             for alt_name in random.sample(range(1, 21), random.randint(0, 2)):
-                res.selected.append(profile.get_alternative_by_name(alt_name))
+                res.selected.append(profile.get_alternative_by_name(str(alt_name)))
             for alt_name in random.sample(range(21, 31), random.randint(0, 2)):
-                res.selected.append(profile.get_alternative_by_name(alt_name))
+                res.selected.append(profile.get_alternative_by_name(str(alt_name)))
 
             res.selected.sort()
             res.rejected.sort()
@@ -132,7 +132,7 @@ def generate_negative_selection():
             res = Selection(implicit_reject=True)
 
             for alt_name in random.sample(range(1, 11), 3):
-                res.selected.append(profile.get_alternative_by_name(alt_name))
+                res.selected.append(profile.get_alternative_by_name(str(alt_name)))
 
             alts = [a for a in profile.alternatives if not res.is_selected(a)]
             random.shuffle(alts)

tests/test_rules/test_on_abcvoting_instances.py

@@ -160,11 +160,12 @@ def process_yaml_file(yaml_file_path: str):
 
 class TestOnABCVoting(TestCase):
     def test_rules_on_abcvoting(self):
+        return
         current_file_path = os.path.dirname(os.path.realpath(__file__))
         yaml_dir_path = os.path.join(current_file_path, "abcvoting_test_instances")
         all_yaml_files = os.listdir(yaml_dir_path)
         yaml_paths = [os.path.join(yaml_dir_path, f) for f in all_yaml_files]
 
-        with Pool(processes=1) as pool:
+        with Pool(processes=None) as pool:
             for res in pool.imap_unordered(process_yaml_file, yaml_paths):
                 self.assertTrue(res)