Skip to content

Commit 2586fe5

Browse files
Merge pull request #580 from CPS-IT/fix/join
[BUGFIX] Loosen type for join parts in `join` helper
2 parents 8f4d4cf + 8bb474b commit 2586fe5

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

Classes/Renderer/Helper/JoinHelper.php

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,21 @@
2929
#[Attribute\AsHelper('join')]
3030
final readonly class JoinHelper implements Helper
3131
{
32-
public function render(Handlebars\HelperOptions $options, string|\Stringable ...$parts): string
32+
public function render(Handlebars\HelperOptions $options, mixed ...$parts): string
3333
{
34-
return implode('', $parts);
34+
return implode('', array_map($this->convertToString(...), $parts));
35+
}
36+
37+
private function convertToString(mixed $value): ?string
38+
{
39+
if (is_scalar($value)) {
40+
return (string)$value;
41+
}
42+
43+
if ($value instanceof \Stringable) {
44+
return (string)$value;
45+
}
46+
47+
return null;
3548
}
3649
}

0 commit comments

Comments
 (0)