feat: migrate opening drill logging endpoints to new api schema

Author: kevinjosethomas

src/api/openings.ts

@@ -1,59 +1,17 @@
 import { buildUrl } from './utils'
 
-// API Types for opening drill logging
-export interface OpeningDrillSelection {
+export interface LogOpeningDrillRequest {
   opening_fen: string
   side_played: string
-}
-
-export interface SelectOpeningDrillsRequest {
-  openings: OpeningDrillSelection[]
   opponent: string
   num_moves: number
-  num_drills: number
-}
-
-export interface SelectOpeningDrillsResponse {
-  session_id: string
-}
-
-export interface SubmitOpeningDrillRequest {
-  session_id: string
-  opening_fen: string
-  side_played: string
   moves_played_uci: string[]
 }
 
-// API function to log opening drill selections and start a session
-export const selectOpeningDrills = async (
-  request: SelectOpeningDrillsRequest,
-): Promise<SelectOpeningDrillsResponse> => {
-  const res = await fetch(buildUrl('opening/select_opening_drills'), {
-    method: 'POST',
-    headers: {
-      Accept: 'application/json',
-      'Content-Type': 'application/json',
-    },
-    body: JSON.stringify(request),
-  })
-
-  if (res.status === 401) {
-    throw new Error('Unauthorized')
-  }
-
-  if (!res.ok) {
-    throw new Error(`Failed to select opening drills: ${res.statusText}`)
-  }
-
-  const data = await res.json()
-  return data as SelectOpeningDrillsResponse
-}
-
-// API function to submit a completed opening drill
-export const submitOpeningDrill = async (
-  request: SubmitOpeningDrillRequest,
+export const logOpeningDrill = async (
+  request: LogOpeningDrillRequest,
 ): Promise<void> => {
-  const res = await fetch(buildUrl('opening/record_opening_drill'), {
+  const res = await fetch(buildUrl('opening/log_opening_drill'), {
     method: 'POST',
     headers: {
       Accept: 'application/json',
@@ -67,6 +25,6 @@ export const submitOpeningDrill = async (
   }
 
   if (!res.ok) {
-    throw new Error(`Failed to submit opening drill: ${res.statusText}`)
+    throw new Error(`Failed to log opening drill: ${res.statusText}`)
   }
 }

src/components/Openings/OpeningSelectionModal.tsx

@@ -22,7 +22,6 @@ import {
   trackDrillConfigurationCompleted,
 } from 'src/lib/analytics'
 import { MAIA_MODELS_WITH_NAMES } from 'src/constants/common'
-import { selectOpeningDrills } from 'src/api/openings'
 
 type MobileTab = 'browse' | 'selected'
 
@@ -991,65 +990,41 @@ export const OpeningSelectionModal: React.FC<Props> = ({
     }
   }
 
-  const handleStartDrilling = async () => {
-    if (selections.length > 0) {
-      try {
-        // Prepare API request data
-        const openings = selections.map((selection) => ({
-          opening_fen: selection.variation
-            ? selection.variation.fen
-            : selection.opening.fen,
-          side_played: selection.playerColor,
-        }))
-
-        // Call the backend API to log opening selections and get session ID
-        const response = await selectOpeningDrills({
-          openings,
-          opponent: selectedMaiaVersion.id,
-          num_moves: targetMoveNumber,
-          num_drills: selections.length, // Use selections length instead of separate drill count
-        })
-
-        const configuration: DrillConfiguration = {
-          selections,
-          sessionId: response.session_id,
-        }
+  const handleStartDrilling = () => {
+    if (selections.length === 0) {
+      return
+    }
 
-        // Track drill configuration completion
-        const uniqueOpenings = new Set(selections.map((s) => s.opening.id)).size
-        const averageTargetMoves =
-          selections.reduce((sum, s) => sum + s.targetMoveNumber, 0) /
-          selections.length
-        const maiaVersionsUsed = [
-          ...new Set(selections.map((s) => s.maiaVersion)),
-        ]
-        const colorDistribution = selections.reduce(
-          (acc, s) => {
-            acc[s.playerColor]++
-            return acc
-          },
-          { white: 0, black: 0 },
-        )
+    const configuration: DrillConfiguration = {
+      selections,
+    }
 
-        trackDrillConfigurationCompleted(
-          selections.length,
-          selections.length, // Use selections length for drill count
-          uniqueOpenings,
-          averageTargetMoves,
-          maiaVersionsUsed,
-          colorDistribution,
-        )
+    // Track drill configuration completion
+    const uniqueOpenings = new Set(selections.map((s) => s.opening.id)).size
+    const averageTargetMoves =
+      selections.reduce((sum, s) => sum + s.targetMoveNumber, 0) /
+      selections.length
+    const maiaVersionsUsed = [
+      ...new Set(selections.map((s) => s.maiaVersion)),
+    ]
+    const colorDistribution = selections.reduce(
+      (acc, s) => {
+        acc[s.playerColor]++
+        return acc
+      },
+      { white: 0, black: 0 },
+    )
 
-        onComplete(configuration)
-      } catch (error) {
-        console.error('Failed to start drilling session:', error)
-        // Still allow the drill to start even if API call fails
-        const configuration: DrillConfiguration = {
-          selections,
-        }
-        onComplete(configuration)
-      }
-    }
+    trackDrillConfigurationCompleted(
+      selections.length,
+      selections.length, // Use selections length for drill count
+      uniqueOpenings,
+      averageTargetMoves,
+      maiaVersionsUsed,
+      colorDistribution,
+    )
+
+    onComplete(configuration)
   }
 
   return (

src/hooks/useOpeningDrillController/useOpeningDrillController.ts

@@ -1,6 +1,6 @@
 import { Chess } from 'chess.ts'
 import { fetchGameMove } from 'src/api/play'
-import { submitOpeningDrill } from 'src/api/openings'
+import { logOpeningDrill } from 'src/api/openings'
 import { useLocalStorage } from '../useLocalStorage'
 import { GameTree, GameNode, Color } from 'src/types'
 import { useState, useMemo, useCallback, useEffect, useRef } from 'react'
@@ -449,21 +449,20 @@ export const useOpeningDrillController = (
       try {
         setIsAnalyzingDrill(true)
 
-        // Submit drill data to backend if session ID is available
-        if (configuration.sessionId) {
-          try {
-            await submitOpeningDrill({
-              session_id: configuration.sessionId,
-              opening_fen: drillGame.selection.variation
-                ? drillGame.selection.variation.fen
-                : drillGame.selection.opening.fen,
-              side_played: drillGame.selection.playerColor,
-              moves_played_uci: drillGame.moves,
-            })
-          } catch (error) {
-            console.error('Failed to submit drill to backend:', error)
-            // Continue even if backend submission fails
-          }
+        // Submit drill data to backend once the drill is complete
+        try {
+          await logOpeningDrill({
+            opening_fen: drillGame.selection.variation
+              ? drillGame.selection.variation.fen
+              : drillGame.selection.opening.fen,
+            side_played: drillGame.selection.playerColor,
+            opponent: drillGame.selection.maiaVersion,
+            num_moves: drillGame.moves.length,
+            moves_played_uci: drillGame.moves,
+          })
+        } catch (error) {
+          console.error('Failed to log opening drill:', error)
+          // Continue even if backend submission fails
         }
 
         // Simple performance evaluation without complex analysis tracking
@@ -481,26 +480,10 @@ export const useOpeningDrillController = (
         setIsAnalyzingDrill(false)
       }
     },
-    [currentDrillGame, evaluateDrillPerformance, configuration.sessionId],
+    [currentDrillGame, evaluateDrillPerformance],
   )
 
   const moveToNextDrill = useCallback(async () => {
-    // Submit drill data to backend if session ID is available
-    if (configuration.sessionId && currentDrillGame) {
-      try {
-        await submitOpeningDrill({
-          session_id: configuration.sessionId,
-          opening_fen: currentDrillGame.selection.variation
-            ? currentDrillGame.selection.variation.fen
-            : currentDrillGame.selection.opening.fen,
-          side_played: currentDrillGame.selection.playerColor,
-          moves_played_uci: currentDrillGame.moves,
-        })
-      } catch (error) {
-        console.error('Failed to submit drill to backend:', error)
-      }
-    }
-
     setShowPerformanceModal(false)
     setCurrentPerformanceData(null)
     setContinueAnalyzingMode(false)
@@ -512,8 +495,6 @@ export const useOpeningDrillController = (
   }, [
     currentDrillIndex,
     configuration.selections,
-    configuration.sessionId,
-    currentDrillGame,
   ])
 
   // Navigate to a specific drill by index

src/types/openings.ts

@@ -27,7 +27,6 @@ export interface OpeningSelection {
 
 export interface DrillConfiguration {
   selections: OpeningSelection[]
-  sessionId?: string
 }
 
 export interface OpeningDrillState {