chore: clean up components+names

Author: kevinjosethomas

src/api/analysis.ts

@@ -72,7 +72,9 @@ export const fetchPgnOfLichessGame = async (id: string): Promise<string> => {
   return res.text()
 }
 
-export const fetchAnalyzedTournamentGame = async (gameId = ['FkgYSri1']) => {
+export const fetchAnalyzedWorldChampionshipGame = async (
+  gameId = ['FkgYSri1'],
+) => {
   const res = await fetch(
     buildUrl(`analysis/analysis_list/${gameId.join('/')}`),
   )

src/components/Analysis/AnalysisGameList.tsx

@@ -16,8 +16,6 @@ import {
   getFavoritesAsWebGames,
   addFavoriteGame,
   removeFavoriteGame,
-  updateFavoriteName,
-  isFavoriteGame,
 } from 'src/lib/favorites'
 import { MaiaGameListEntry } from 'src/types'
 import { useRouter } from 'next/router'

src/pages/analysis/[...id].tsx

@@ -11,7 +11,7 @@ import {
   fetchPgnOfLichessGame,
   fetchAnalyzedMaiaGame,
   fetchAnalyzedPgnGame,
-  fetchAnalyzedTournamentGame,
+  fetchAnalyzedWorldChampionshipGame,
   retrieveGameAnalysisCache,
 } from 'src/api'
 import {
@@ -100,7 +100,7 @@ const AnalysisPage: NextPage = () => {
     ) => {
       let game
       try {
-        game = await fetchAnalyzedTournamentGame(newId)
+        game = await fetchAnalyzedWorldChampionshipGame(newId)
       } catch (e) {
         router.push('/401')
         return

src/types/analysis.ts

@@ -1,7 +1,6 @@
 import { Player } from './player'
+import { BaseGame } from './common'
 import { AvailableMoves } from './puzzle'
-import { Dispatch, SetStateAction } from 'react'
-import { BaseGame, GameNode, GameTree } from './common'
 
 export interface MoveValueMapping {
   [move: string]: number
@@ -16,19 +15,6 @@ export interface AnalyzedGame extends BaseGame {
   termination?: Termination
 }
 
-export interface BaseTreeControllerContext {
-  gameTree: GameTree
-  currentNode: GameNode
-  setCurrentNode: Dispatch<SetStateAction<GameNode>>
-  goToNode: (node: GameNode) => void
-  goToNextNode: () => void
-  goToPreviousNode: () => void
-  goToRootNode: () => void
-  plyCount: number
-  orientation: 'white' | 'black'
-  setOrientation: (orientation: 'white' | 'black') => void
-}
-
 export interface MaiaEvaluation {
   value: number
   policy: { [key: string]: number }

src/types/common.ts

@@ -1,4 +1,5 @@
-import { GameTree } from './tree'
+import { GameNode, GameTree } from './tree'
+import { Dispatch, SetStateAction } from 'react'
 
 export * from './tree'
 
@@ -19,3 +20,16 @@ export interface RawMove {
 export type Check = false | 'white' | 'black'
 
 export type Color = 'white' | 'black'
+
+export interface BaseTreeControllerContext {
+  gameTree: GameTree
+  currentNode: GameNode
+  setCurrentNode: Dispatch<SetStateAction<GameNode>>
+  goToNode: (node: GameNode) => void
+  goToNextNode: () => void
+  goToPreviousNode: () => void
+  goToRootNode: () => void
+  plyCount: number
+  orientation: 'white' | 'black'
+  setOrientation: (orientation: 'white' | 'black') => void
+}