fix: stockfish perspective + description not updating

Author: kevinjosethomas

src/hooks/useAnalysisController/useAnalysisController.ts

@@ -112,8 +112,6 @@ export const useAnalysisController = (
   const boardDescription = useBoardDescription(
     controller.currentNode || null,
     moveEvaluation,
-    blunderMeter,
-    colorSanMapping,
   )
 
   const move = useMemo(() => {

src/hooks/useAnalysisController/useBoardDescription.ts

@@ -1,28 +1,14 @@
 import { useMemo } from 'react'
-import {
-  BlunderMeterResult,
-  GameNode,
-  MaiaEvaluation,
-  StockfishEvaluation,
-} from 'src/types'
+import { GameNode, MaiaEvaluation, StockfishEvaluation } from 'src/types'
 import { MAIA_MODELS } from './constants'
 import { describePosition } from './useDescriptionGenerator'
 
-type ColorSanMapping = {
-  [move: string]: {
-    san: string
-    color: string
-  }
-}
-
 export const useBoardDescription = (
   currentNode: GameNode | null,
   moveEvaluation: {
     maia?: MaiaEvaluation
     stockfish?: StockfishEvaluation
   } | null,
-  blunderMeter: BlunderMeterResult,
-  colorSanMapping: ColorSanMapping,
 ) => {
   return useMemo(() => {
     if (
@@ -57,6 +43,18 @@ export const useBoardDescription = (
       }
     })
 
-    return describePosition(fen, stockfishEvals, maiaEvals, whiteToMove)
-  }, [currentNode, moveEvaluation])
+    const description = describePosition(
+      fen,
+      stockfishEvals,
+      maiaEvals,
+      whiteToMove,
+    )
+    return description
+  }, [
+    currentNode?.fen,
+    currentNode?.analysis.stockfish?.depth,
+    currentNode?.analysis.maia,
+    moveEvaluation?.stockfish?.depth,
+    moveEvaluation?.maia?.policy,
+  ])
 }

src/hooks/useAnalysisController/useDescriptionGenerator.ts

@@ -69,6 +69,7 @@ export function describePosition(
   fen: string,
   sf: StockfishEvals,
   maia: MaiaEvals,
+  whiteToMove: boolean,
 ): string {
   /* ---------- board ---------- */
   const chess = new Chess(fen)
@@ -80,6 +81,10 @@ export function describePosition(
   const moves = Object.keys(sf).filter((m) => legal.has(m))
   if (!moves.length) return 'No legal moves available.'
 
+  if (!whiteToMove) {
+    sf = Object.fromEntries(Object.entries(sf).map(([m, v]) => [m, -v]))
+  }
+
   /* ---------- evals (side-to-move) ---------- */
   const seval: Record<string, number> = {}
   for (const m of moves) seval[m] = sf[m]
@@ -266,9 +271,12 @@ export function describePosition(
 
   /* ---------- assemble ---------- */
   const moveList = bestHarder ? listWithoutOpt : listWithOpt
-  return nGood === 1
-    ? `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}.${tail}`
-    : bestHarder
-      ? `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}, but the best move (${bestMoveSan}) is ${phrBest}.${tail}`
-      : `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}.${tail}`
+  const result =
+    nGood === 1
+      ? `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}.${tail}`
+      : bestHarder
+        ? `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}, but the best move (${bestMoveSan}) is ${phrBest}.${tail}`
+        : `There ${verb} ${abundance} (${moveList}) ${outcome}, and ${pron} ${phrSet}.${tail}`
+
+  return result
 }