Skip to content

Fix Stockfish move color ordering in analysis#268

Merged
ashtonanderson merged 1 commit into
mainfrom
codex/fix-stockfish-move-colors
Mar 28, 2026
Merged

Fix Stockfish move color ordering in analysis#268
ashtonanderson merged 1 commit into
mainfrom
codex/fix-stockfish-move-colors

Conversation

@ashtonanderson
Copy link
Copy Markdown
Member

Summary

  • add a shared Stockfish move sorter based on the same ranking metrics used for coloring
  • use that sorter for Stockfish recommendations and top move selection instead of object key order
  • use model_move for the Stockfish arrow rather than assuming the first cp_vec entry is best

Problem

The analysis UI was ordering Stockfish moves from cp_vec, while move colors were derived from winrate_loss_vec or cp_relative_vec. Once those object orders diverged, weaker light-green moves could appear above stronger dark-green moves.

Testing

  • npx tsc --noEmit

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maia-platform-frontend Ready Ready Preview, Comment Mar 28, 2026 0:52am

Request Review

@ashtonanderson ashtonanderson merged commit ba0b19e into main Mar 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant