Skip to content

Commit 141a9ae

Browse files
committed
chore(tables): rename the rest of the DB tables
1 parent 12bd99f commit 141a9ae

7 files changed

Lines changed: 32 additions & 37 deletions

File tree

src/auth/crud.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import sqlalchemy
55
from sqlalchemy.ext.asyncio import AsyncSession
66

7-
from auth.tables import SiteUserDB, UserSession
7+
from auth.tables import SiteUserDB, UserSessionDB
88

99
_logger = logging.getLogger(__name__)
1010

@@ -16,7 +16,7 @@ async def create_user_session(db_session: AsyncSession, session_id: str, computi
1616
Also, adds the new user to the SiteUser table if it's their first time logging in.
1717
"""
1818
existing_user_session = await db_session.scalar(
19-
sqlalchemy.select(UserSession).where(UserSession.computing_id == computing_id)
19+
sqlalchemy.select(UserSessionDB).where(UserSessionDB.computing_id == computing_id)
2020
)
2121
existing_user = await db_session.scalar(
2222
sqlalchemy.select(SiteUserDB).where(SiteUserDB.computing_id == computing_id)
@@ -40,7 +40,7 @@ async def create_user_session(db_session: AsyncSession, session_id: str, computi
4040
existing_user.last_logged_in = datetime.now(UTC)
4141
else:
4242
db_session.add(
43-
UserSession(
43+
UserSessionDB(
4444
session_id=session_id,
4545
computing_id=computing_id,
4646
issue_time=datetime.now(UTC),
@@ -49,13 +49,13 @@ async def create_user_session(db_session: AsyncSession, session_id: str, computi
4949

5050

5151
async def remove_user_session(db_session: AsyncSession, session_id: str):
52-
query = sqlalchemy.select(UserSession).where(UserSession.session_id == session_id)
52+
query = sqlalchemy.select(UserSessionDB).where(UserSessionDB.session_id == session_id)
5353
user_session = await db_session.scalars(query)
5454
await db_session.delete(user_session.first())
5555

5656

5757
async def get_computing_id(db_session: AsyncSession, session_id: str) -> str | None:
58-
query = sqlalchemy.select(UserSession).where(UserSession.session_id == session_id)
58+
query = sqlalchemy.select(UserSessionDB).where(UserSessionDB.session_id == session_id)
5959
existing_user_session = (await db_session.scalars(query)).first()
6060
return existing_user_session.computing_id if existing_user_session else None
6161

@@ -64,14 +64,14 @@ async def get_computing_id(db_session: AsyncSession, session_id: str) -> str | N
6464
async def task_clean_expired_user_sessions(db_session: AsyncSession):
6565
one_day_ago = datetime.now(UTC) - timedelta(days=0.5)
6666

67-
query = sqlalchemy.delete(UserSession).where(UserSession.issue_time < one_day_ago)
67+
query = sqlalchemy.delete(UserSessionDB).where(UserSessionDB.issue_time < one_day_ago)
6868
await db_session.execute(query)
6969
await db_session.commit()
7070

7171

7272
# get the site user given a session ID; returns None when session is invalid
7373
async def get_site_user(db_session: AsyncSession, session_id: str) -> SiteUserDB | None:
74-
query = sqlalchemy.select(UserSession).where(UserSession.session_id == session_id)
74+
query = sqlalchemy.select(UserSessionDB).where(UserSessionDB.session_id == session_id)
7575
user_session = await db_session.scalar(query)
7676
if user_session is None:
7777
return None
@@ -87,7 +87,7 @@ async def site_user_exists(db_session: AsyncSession, computing_id: str) -> bool:
8787

8888
# update the optional user info for a given site user (e.g., display name, profile picture, ...)
8989
async def update_site_user(db_session: AsyncSession, session_id: str, profile_picture_url: str) -> bool:
90-
query = sqlalchemy.select(UserSession).where(UserSession.session_id == session_id)
90+
query = sqlalchemy.select(UserSessionDB).where(UserSessionDB.session_id == session_id)
9191
user_session = await db_session.scalar(query)
9292
if user_session is None:
9393
return False

src/auth/tables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from database import Base
88

99

10-
class UserSession(Base):
10+
class UserSessionDB(Base):
1111
__tablename__ = "user_session"
1212

1313
computing_id: Mapped[str] = mapped_column(

src/blog/tables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77

88
# blog table
9-
class BlogPosts(Base):
9+
class BlogPostsDB(Base):
1010
# table name
1111
__tablename__ = "blog_posts"
1212

src/load_test_db.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from elections.crud import create_election, update_election
1616
from elections.tables import ElectionDB
1717
from nominees.crud import create_nominee_info
18-
from nominees.tables import NomineeInfo
18+
from nominees.tables import NomineeInfoDB
1919
from officers.constants import OfficerPositionEnum
2020
from officers.crud import (
2121
create_new_officer_info,
@@ -397,7 +397,7 @@ async def load_test_elections_data(db_session: AsyncSession):
397397
)
398398
await create_nominee_info(
399399
db_session,
400-
NomineeInfo(
400+
NomineeInfoDB(
401401
computing_id="jdo12",
402402
full_name="John Doe",
403403
linked_in="linkedin.com/john-doe",
@@ -408,7 +408,7 @@ async def load_test_elections_data(db_session: AsyncSession):
408408
)
409409
await create_nominee_info(
410410
db_session,
411-
NomineeInfo(
411+
NomineeInfoDB(
412412
computing_id="pkn4",
413413
full_name="Puneet North",
414414
linked_in="linkedin.com/john-doe3",

src/nominees/crud.py

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,48 +3,43 @@
33
import sqlalchemy
44
from sqlalchemy.ext.asyncio import AsyncSession
55

6-
from nominees.tables import NomineeInfo
6+
from nominees.tables import NomineeInfoDB
77

88

99
async def get_all_nominees(
1010
db_session: AsyncSession,
11-
) -> Sequence[NomineeInfo]:
12-
nominees = (await db_session.scalars(
13-
sqlalchemy
14-
.select(NomineeInfo)
15-
)).all()
11+
) -> Sequence[NomineeInfoDB]:
12+
nominees = (await db_session.scalars(sqlalchemy.select(NomineeInfoDB))).all()
1613
return nominees
1714

15+
1816
async def get_nominee_info(
1917
db_session: AsyncSession,
2018
computing_id: str,
21-
) -> NomineeInfo | None:
22-
return await db_session.scalar(sqlalchemy.select(NomineeInfo).where(NomineeInfo.computing_id == computing_id))
19+
) -> NomineeInfoDB | None:
20+
return await db_session.scalar(sqlalchemy.select(NomineeInfoDB).where(NomineeInfoDB.computing_id == computing_id))
2321

2422

2523
async def create_nominee_info(
2624
db_session: AsyncSession,
27-
info: NomineeInfo,
25+
info: NomineeInfoDB,
2826
):
2927
db_session.add(info)
3028

3129

3230
async def update_nominee_info(
3331
db_session: AsyncSession,
34-
info: NomineeInfo,
32+
info: NomineeInfoDB,
3533
):
3634
await db_session.execute(
37-
sqlalchemy.update(NomineeInfo)
38-
.where(NomineeInfo.computing_id == info.computing_id)
35+
sqlalchemy.update(NomineeInfoDB)
36+
.where(NomineeInfoDB.computing_id == info.computing_id)
3937
.values(info.to_update_dict())
4038
)
4139

40+
4241
async def delete_nominee_info(
43-
db_session: AsyncSession,
44-
computing_id: str,
42+
db_session: AsyncSession,
43+
computing_id: str,
4544
):
46-
await db_session.execute(
47-
sqlalchemy
48-
.delete(NomineeInfo)
49-
.where(NomineeInfo.computing_id == computing_id)
50-
)
45+
await db_session.execute(sqlalchemy.delete(NomineeInfoDB).where(NomineeInfoDB.computing_id == computing_id))

src/nominees/tables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from database import Base
1111

1212

13-
class NomineeInfo(Base):
13+
class NomineeInfoDB(Base):
1414
__tablename__ = "election_nominee_info"
1515

1616
computing_id: Mapped[str] = mapped_column(String(COMPUTING_ID_LEN), primary_key=True)

src/nominees/urls.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
NomineeInfoModel,
99
NomineeInfoUpdateParams,
1010
)
11-
from nominees.tables import NomineeInfo
11+
from nominees.tables import NomineeInfoDB
1212
from utils.shared_models import DetailModel
1313

1414
router = APIRouter(
@@ -45,7 +45,7 @@ async def get_all_nominees(
4545
async def create_nominee(db_session: database.DBSession, body: NomineeInfoModel):
4646
await nominees.crud.create_nominee_info(
4747
db_session,
48-
NomineeInfo(
48+
NomineeInfoDB(
4949
computing_id=body.computing_id,
5050
full_name=body.full_name,
5151
linked_in=body.linked_in,
@@ -120,7 +120,7 @@ async def provide_nominee_info(db_session: database.DBSession, body: NomineeInfo
120120
# if not already existing, create it
121121
if not existing_info:
122122
# unpack dictionary and expand into NomineeInfo class
123-
new_nominee_info = NomineeInfo(computing_id=computing_id, **updated_data)
123+
new_nominee_info = NomineeInfoDB(computing_id=computing_id, **updated_data)
124124
# create a new nominee
125125
await nominees.crud.create_nominee_info(db_session, new_nominee_info)
126126
# else just update the partial data
@@ -135,7 +135,7 @@ async def provide_nominee_info(db_session: database.DBSession, body: NomineeInfo
135135
}
136136
# update the dictionary with new data
137137
merged_data.update(updated_data)
138-
updated_nominee_info = NomineeInfo(**merged_data)
138+
updated_nominee_info = NomineeInfoDB(**merged_data)
139139
await nominees.crud.update_nominee_info(db_session, updated_nominee_info)
140140

141141
await db_session.commit()

0 commit comments

Comments
 (0)