Skip to content

Commit 316c1b6

Browse files
committed
chore(OfficerInfoDB): remove unused methods
1 parent 908e6ad commit 316c1b6

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

src/officers/tables.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from __future__ import annotations
22

33
from datetime import date
4-
from typing import Any
54

65
from sqlalchemy import (
76
Date,
@@ -117,23 +116,6 @@ class OfficerInfoDB(Base):
117116
# TODO (#22): add support for giving executives bitwarden access automagically
118117
# has_signed_into_bitwarden: Mapped[str] = mapped_column(Boolean)
119118

120-
def update_from_params(self, params: OfficerUpdate | OfficerUpdate):
121-
update_data = params.model_dump(exclude_unset=True)
122-
for k, v in update_data.items():
123-
setattr(self, k, v)
124-
125-
def is_filled_in(self):
126-
return (
127-
self.computing_id is not None
128-
and self.legal_name is not None
129-
and self.phone_number is not None
130-
and self.discord_id is not None
131-
and self.discord_name is not None
132-
and self.discord_nickname is not None
133-
and self.google_drive_email is not None
134-
and self.github_username is not None
135-
)
136-
137119
def to_update_dict(self) -> dict:
138120
return {
139121
# TODO (#71): if the API call to SFU's api to get legal name fails, we want to fail & not insert the entry.

0 commit comments

Comments
 (0)