Skip to content

Various fixes on Elections API#112

Merged
jbriones1 merged 6 commits into
mainfrom
fix_batch-1
Aug 26, 2025
Merged

Various fixes on Elections API#112
jbriones1 merged 6 commits into
mainfrom
fix_batch-1

Conversation

@jbriones1
Copy link
Copy Markdown
Contributor

@jbriones1 jbriones1 commented Aug 26, 2025 •
edited
Loading

  • Added a response model for the elections and nominee endpoints
  • Fixed some invalid HTTP 404 status code returns
  • Fixed some return type issues on user validations functions

@jbriones1 jbriones1 requested a review from p-north August 26, 2025 04:26
p-north
p-north reviewed Aug 26, 2025
View reviewed changes
Comment thread src/utils/urls.py
p-north
p-north approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@p-north p-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Looks good overall

@jbriones1 jbriones1 merged commit fd23837 into main Aug 26, 2025
3 checks passed
@jbriones1 jbriones1 deleted the fix_batch-1 branch August 26, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north p-north approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbriones1 @p-north