First Elections PR#63
Merged
Merged
Conversation
Open
EarthenSky
commented
Aug 9, 2024
…omineeSepech -> NomineeApplication, changed ForeignKeyConstraints to ForeignKey
…r a user is a current elections officer
EarthenSky
commented
Oct 3, 2024
Collaborator
Author
EarthenSky
left a comment
EarthenSky
left a comment
There was a problem hiding this comment.
I'll do another review round after, but 99% looks good!
EarthenSky
commented
Oct 3, 2024
EarthenSky
commented
Oct 3, 2024
EarthenSky
commented
Oct 4, 2024
EarthenSky
commented
Oct 4, 2024
EarthenSky
commented
Oct 4, 2024
EarthenSky
commented
Oct 4, 2024
EarthenSky
commented
Oct 4, 2024
…ey has been deprecated
…lected changes across urls.py
…n the project. Changed database.DBSession -> AsyncSession to match other crud functions.
Member
|
Alright, brief high level summary. This PR introduces the following:
This still needs to introduce/do the following:
I'll work on these in my next PR. As of this comment, all of the above comments should have been addressed. |
EarthenSky
commented
Jan 13, 2025
EarthenSky
commented
Jan 13, 2025
…e -> end_datetime in elections module.
EarthenSky
commented
Jan 13, 2025
Collaborator
Author
EarthenSky
left a comment
EarthenSky
left a comment
There was a problem hiding this comment.
Oops, since I made this PR originally I can't request changes. However, consider this "request changes".
The biggest issue is the uniqueness of the slug, the rest are medium level.
Mostly the logic is good!
Collaborator
Author
|
This PR creates tables for elections and nominees, while introducing tested endpoints just for the elections (C,R,U,D) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elections PR, woo!