Fix: officer images and links (#240)

closes #235 

Description:
On the Officers page, the app was crashing with "Administration for year 2026 not found" error, preventing the page from rendering. Additionally, external links were not displaying, and executive member photos were failing to load.

Root cause:
The currentAdministration computed property was hardcoded to look for executive administration data matching the current year (2026). Since the 2026 administration data doesn't exist yet in the codebase, the code threw an error instead of gracefully handling the missing data. Additionally, the toLocalUrl() method was looking for images in the executives/2026/ folder when they were actually in executives/2025/.

Fix:
Added fallback logic to use the most recent available administration when the current year's data doesn't exist. The code now uses .reduce() to find the administration with the highest startYear and displays that instead of crashing. Also built the image path inline using the actual administration's startYear instead of calling toLocalUrl(), ensuring images load from the correct year's folder (e.g., executives/2025/ when showing 2025 administration).

Author: connorjonesy

src/app/pages/officers/officers.component.ts

@@ -22,15 +22,16 @@ export class OfficersComponent {
     let newAdmin = this.cachedAdmins.get(year);
     if (!newAdmin) {
       // TODO: Fetch this from the back end.
-      newAdmin = structuredClone(executives.find(e => e.startYear === year));
+      newAdmin = structuredClone(executives.find(e => e.startYear <= year));
       if (!newAdmin) {
-        throw new Error(`Administration for year ${year} not found.`);
+        throw new Error(`Administration not found for any year.`);
       }
+      const foundYear = newAdmin.startYear;
       // FIXME: Remove this once admins are properly fetched.
       newAdmin.members = newAdmin.members.map(exec => {
         return {
           ...exec,
-          photoName: this.toLocalUrl(exec.photoName)
+          photoName: `images/executives/${foundYear}/${exec.photoName}`
         };
       });
       // end of FIXME:
@@ -45,14 +46,4 @@ export class OfficersComponent {
    * Will probably need some way to remove older cached entries if memory becomes an issue.
    */
   private cachedAdmins = new Map<number, ExecutiveAdministration>();
-
-  /**
-   * Changes the files name to one that can be used to set the background image.
-   *
-   * @param fileName - The file name to change. Must be in the `public/images/` folder
-   * @returns File name in the CSS URL form.
-   */
-  private toLocalUrl(fileName: string): string {
-    return `images/executives/${this.currentYear()}/${fileName}`;
-  }
 }