Conversation
|
This pull request has been marked to automatically sync to its base branch. You can disable this behavior by removing the label. |
There was a problem hiding this comment.
Pull request overview
Updates the Guild sales report scraping logic to better handle problematic <input> elements in the MSL context form, and adds additional output when the report viewer fails to load.
Changes:
- Skip
submit/image/button<input>fields when building form data for the MSL request. - Treat inputs with an explicitly empty value (
value="") as valid (only exclude whenvalueis missing/None). - Add extra diagnostic printing when the expected report viewer element is missing/empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| print("Failed to load the reports.") | ||
| print(soup) | ||
| print(report_viewer_div) |
There was a problem hiding this comment.
Avoid printing the full parsed HTML (soup) on failure: it can be very large and may contain sensitive user/org data, leading to noisy logs and potential data exposure. Prefer logging a small, redacted snippet (e.g., status code + relevant div excerpt) and/or gating this behind a debug flag/env var.
No description provided.