Make caching configurable #70
Conversation
MattyTheHacker
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR introduces a new configuration flag to control whether Guild membership lookups use cached data or refresh more aggressively.
Changes:
- Add
platform.cachingboolean to the config schema and load it intoConfig.Platform. - Update
guildScraper.GetMemberto conditionally refresh the membership list based on the new config value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/guildScraper/checkMember.go | Adds config-driven behavior to refresh membership list when caching is disabled. |
| internal/config/config.go | Extends Platform config with a Caching flag and reads platform.caching from config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AdminToken string | ||
| SessionSigningToken string | ||
| DiscordWebhook *DiscordWebhook | ||
| Caching bool |
There was a problem hiding this comment.
Might be worth giving this a more descriptive name like EnableMembershipListCaching or something
not tested and probably doesn't work, priority is #68 for now