Fix fire vase hull scalar mapping and restore legible custom rendering#208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
data -> scalar -> normalization -> mapping -> interpolation -> shading -> projection) for the fire vase while preserving the improved custom interaction model and keeping fixes narrowly scoped to the fire viewer path.Description
plot_climate_filled_hullto ensure per-vertex alignment withverts_kminstead of indexing via rawt_days_vert. (Seesrc/cubedynamics/fire_time_hull.py.)fire_plotdefaults insrc/cubedynamics/verbs/fire.py.)intensitymode="vertex"and keepingflatshading=False, and add a developer diagnosticscalar_debug_mode="z"to color byz(time) for vertical-banding verification. (Seesrc/cubedynamics/fire_time_hull.py.)z_exaggerationparameter applied to the Plotly sceneaspectratioso the vase reads taller without mutating scientific coordinates, and reduce scene scaffolding (background/grid/zeroline suppressed) for a cleaner presentation. (Exposed throughfire_plotand forwarded to the hull renderer.)tests/test_fire_hull_viewer_scalars.pyto verify scalar-to-vertex ordering, thezdiagnostic mapping, and thatz_exaggerationis applied.Testing
tests/test_fire_hull_viewer_scalars.pywhich validate layer-ordered scalar attachment,scalar_debug_mode="z", andz_exaggerationapplication.pytest -q tests/test_fire_hull_viewer_scalars.py tests/test_fire_plot_cube_first.pyand all tests passed in this environment.src/cubedynamics/fire_time_hull.py,src/cubedynamics/verbs/fire.py, and the new test filetests/test_fire_hull_viewer_scalars.py.Codex Task