Fixing linting issues from last commit

Author: afoote-mitre

src/repositories/baseUserRepository.js

@@ -412,14 +412,14 @@ class BaseUserRepository extends BaseRepository {
    * @param {boolean} [isRegistryObject=true] - If false, returns a legacy user object.
    * @returns {Promise<object>} The updated user object.
    */
-async updateUser (username, orgShortname, incomingParameters, options = {}, isRegistryObject = true, requestingUserUUID = null) {
+  async updateUser (username, orgShortname, incomingParameters, options = {}, isRegistryObject = true, requestingUserUUID = null) {
     const { deepRemoveEmpty } = require('../utils/utils')
     const baseOrgRepository = new BaseOrgRepository()
     const legacyUserRepo = new UserRepository()
     const { createAuditLogEntry } = require('./baseOrgRepositoryHelpers')
     const registryOrg = await baseOrgRepository.getOrgObject(orgShortname, false, options)
     const originalRegistryOrg = registryOrg.toObject()
-    
+
     const legacyUser = await legacyUserRepo.findOneByUserNameAndOrgUUID(username, registryOrg.UUID, null, options)
     const registryUser = await this.findOneByUsernameAndOrgShortname(username, orgShortname, options, true)
 
@@ -455,7 +455,7 @@ async updateUser (username, orgShortname, incomingParameters, options = {}, isRe
 
     const rolesToAdd = _.flattenDeep(_.compact(_.get(incomingParameters, 'active_roles.add')))
     const rolesToRemove = _.flattenDeep(_.compact(_.get(incomingParameters, 'active_roles.remove')))
-    
+
     if (rolesToRemove.includes('ADMIN') && userUUID) {
       if (Array.isArray(registryOrg.admins)) {
         registryOrg.admins.pull(userUUID)
@@ -472,7 +472,7 @@ async updateUser (username, orgShortname, incomingParameters, options = {}, isRe
     // Handle roles calculation fallback
     const initialRoles = legacyUser?.authority?.active_roles ?? []
     const finalRoles = [...new Set([...initialRoles, ...rolesToAdd])].filter(role => !rolesToRemove.includes(role))
-    
+
     if (registryUser) {
       registryUser.role = finalRoles[0] ?? ''
     }
@@ -487,7 +487,7 @@ async updateUser (username, orgShortname, incomingParameters, options = {}, isRe
       if (registryOrg.admins && registryOrg.admins.includes(userUUID)) {
         registryOrg.admins.pull(userUUID)
       }
-      
+
       const newOrg = await baseOrgRepository.getOrgObject(incomingParameters.org_short_name)
       const originalNewOrg = newOrg.toObject()
       if (!Array.isArray(newOrg.users)) {
@@ -515,7 +515,7 @@ async updateUser (username, orgShortname, incomingParameters, options = {}, isRe
     if (registryUser) {
       delete registryUser.role
     }
-    
+
     await registryOrg.save(options)
     if (requestingUserUUID) {
       await createAuditLogEntry(registryOrg, originalRegistryOrg, requestingUserUUID, options)
@@ -554,20 +554,20 @@ async updateUser (username, orgShortname, incomingParameters, options = {}, isRe
    * @param {boolean} [isRegistryObject=true] - If false, accepts/returns legacy format.
    * @returns {Promise<object>} The updated user object.
    */
-async updateUserFull (identifier, incomingUser, options = {}, isRegistryObject = true, requestingUserUUID = null) {
+  async updateUserFull (identifier, incomingUser, options = {}, isRegistryObject = true, requestingUserUUID = null) {
     const legacyUserRepo = new UserRepository()
 
     const registryUser = await this.findUserByUUID(identifier, options)
     const legacyUser = await legacyUserRepo.findOneByUUID(identifier)
-    
+
     // Fail only if completely missing everywhere
     if (!registryUser && !legacyUser) {
       throw new Error('User not found in any repository')
     }
 
     const { ...incomingUserBody } = incomingUser
-    let legacyObjectRaw = isRegistryObject ? this.convertRegistryToLegacy(incomingUserBody) : incomingUserBody
-    let registryObjectRaw = isRegistryObject ? incomingUserBody : this.convertLegacyToRegistry(incomingUserBody)
+    const legacyObjectRaw = isRegistryObject ? this.convertRegistryToLegacy(incomingUserBody) : incomingUserBody
+    const registryObjectRaw = isRegistryObject ? incomingUserBody : this.convertLegacyToRegistry(incomingUserBody)
 
     const protectedFieldsRegistry = ['_id', 'UUID', '__v', 'secret', 'created', 'last_updated']
     const protectedFieldsLegacy = ['_id', 'UUID', '__v', 'secret', 'time', 'org_UUID']
@@ -593,7 +593,7 @@ async updateUserFull (identifier, incomingUser, options = {}, isRegistryObject =
       if (incomingUser.org_short_name) {
         const baseOrgRepository = new BaseOrgRepository()
         const { createAuditLogEntry } = require('./baseOrgRepositoryHelpers')
-        
+
         // Grab current org UUID using whichever document is real
         const currentOrgUUID = legacyUser ? legacyUser.org_UUID : registryUser?.org_UUID // Fallback if schema supports it
         const currentOrg = currentOrgUUID ? await baseOrgRepository.findOneByUUID(currentOrgUUID) : null
@@ -638,7 +638,6 @@ async updateUserFull (identifier, incomingUser, options = {}, isRegistryObject =
       // Conditionally save records
       if (updatedLegacyUser) await updatedLegacyUser.save(options)
       if (updatedRegistryUser) await updatedRegistryUser.save(options)
-      
     } catch (error) {
       throw new Error('Failed to update user: ' + error.message)
     }
@@ -666,7 +665,7 @@ async updateUserFull (identifier, incomingUser, options = {}, isRegistryObject =
    * @param {boolean} [isRegistryObject=true] - Unused parameter.
    * @returns {Promise<string>} The new random secret key.
    */
-async resetSecret (username, orgShortName, options = {}, isRegistryObject = true) {
+  async resetSecret (username, orgShortName, options = {}, isRegistryObject = true) {
     const legacyUserRepo = new UserRepository()
     const baseOrgRepository = new BaseOrgRepository()